Skip to content

Modernize docs CI and dependency maintenance - #20

Merged
next-devin merged 2 commits into
mainfrom
docs-ci-maintenance
Jul 31, 2026
Merged

Modernize docs CI and dependency maintenance#20
next-devin merged 2 commits into
mainfrom
docs-ci-maintenance

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

Summary

  • upgrade actions/checkout and actions/setup-node to v6
  • split production build and dependency audit into independent required signals
  • update Next.js and override vulnerable PostCSS and Sharp transitive versions
  • add weekly Dependabot maintenance for npm and GitHub Actions

Why

A newly published dependency advisory caused npm audit to stop the CI job before the documentation build ran. The workflow also used v4 Actions running on the deprecated Node 20 action runtime.

Validation

  • npm ci
  • npm audit --omit=dev — 0 vulnerabilities
  • npm run build — link checks pass and 268 static pages build
  • actionlint .github/workflows/ci.yml

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 31, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs 9ac933c Commit Preview URL

Branch Preview URL
Jul 31 2026, 08:57 AM

@next-devin
next-devin marked this pull request as ready for review July 31, 2026 08:44
Comment thread .github/workflows/ci.yml Outdated
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: actions/checkout@v6 is pinned to a mutable major-version tag. A compromised tag retag would silently swap the action implementation on every CI run. Pin to the full commit SHA (e.g. actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11) and reference # v6.0.0 in a comment for upgrades.

This applies to actions/checkout@v6 (lines 13, 27) and actions/setup-node@v6 (lines 15, 29).


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Comment thread .github/workflows/ci.yml

- run: npm run build

security-audit:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: The new security-audit job skips npm ci/npm install and runs npm audit --omit=dev directly on a fresh checkout. While npm audit reads package-lock.json without node_modules, this diverges from how the build job resolves dependencies and can mask vulnerabilities whose fix relies on npm install resolution (e.g. overrides, peer-dep-driven resolutions) being materialized. Consider running npm ci before npm audit so both jobs share the same resolved tree.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Comment thread .github/dependabot.yml
interval: weekly
open-pull-requests-limit: 5

- package-ecosystem: github-actions

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Add a groups block (and consider labels) so weekly Dependabot runs batch related Action updates into a single PR. As written, every action version bump on its own dependency will open a separate PR up to open-pull-requests-limit: 5, which can quickly exhaust the limit and stall security updates. Example:

groups:
  actions:
    patterns:
      - "*"

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Comment thread package.json Outdated
"overrides": {
"postcss": "8.5.10"
"postcss": "8.5.25",
"sharp": "0.35.3"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: The new sharp override pins a transitive of next (optionalDependencies: "sharp": "^0.34.5") to 0.35.3 — a major-version jump. Sharp 0.35 introduced changes to libvips packaging (new @img/sharp-wasm32/@img/sharp-webcontainers-wasm32 variants, broader libc classification) and may include image-processing API or default-behavior changes that affect Next.js image optimization output. Recommend: (1) diff Next.js's usage of sharp's public API against 0.35's changelog, (2) re-run the production build and visually verify a representative image pipeline (next/image with optimization) before merging, and (3) consider pinning to the latest 0.34.x patch instead if the only goal is the advisory fix.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/ci.yml 13 actions/checkout@v6 / actions/setup-node@v6 pinned to mutable major tags — supply-chain risk; pin to commit SHA
.github/workflows/ci.yml 24 New security-audit job omits npm ci, diverging from the build job's resolved tree
package.json 39 sharp override forces a transitive from ^0.34.5 to 0.35.3 — major-version jump; validate Next.js image pipeline still works

SUGGESTION

File Line Issue
.github/dependabot.yml 10 GitHub Actions update lacks a groups block — weekly bumps will open up to 5 separate PRs and may stall security updates
Files Reviewed (4 files)
  • .github/dependabot.yml - 1 issue
  • .github/workflows/ci.yml - 2 issues
  • package.json - 1 issue
  • package-lock.json - 0 issues (auto-generated lockfile changes; no manual review)

Fix these issues in Kilo Cloud

Previous Review Summary (commit 5a779ee)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 5a779ee)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/ci.yml 13 actions/checkout@v6 / actions/setup-node@v6 pinned to mutable major tags — supply-chain risk; pin to commit SHA
.github/workflows/ci.yml 24 New security-audit job omits npm ci, diverging from the build job's resolved tree
package.json 39 sharp override forces a transitive from ^0.34.5 to 0.35.3 — major-version jump; validate Next.js image pipeline still works

SUGGESTION

File Line Issue
.github/dependabot.yml 10 GitHub Actions update lacks a groups block — weekly bumps will open up to 5 separate PRs and may stall security updates
Files Reviewed (4 files)
  • .github/dependabot.yml - 1 issue
  • .github/workflows/ci.yml - 2 issues
  • package.json - 1 issue
  • package-lock.json - 0 issues (auto-generated lockfile changes; no manual review)

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 22.8K · Output: 931 · Cached: 56.3K

@next-devin
next-devin merged commit 4f48546 into main Jul 31, 2026
5 checks passed
@next-devin
next-devin deleted the docs-ci-maintenance branch July 31, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant