[codex] Restore MQL MetaEditor compilation#115
Merged
Conversation
Adjust MQL5 DateTime construction and ISO date validation for MetaEditor, and expose MQL4 TimeShield constant access through static methods.
Replace MQL4 TimeShield constant accessor methods with typed global TSHIELD-prefixed constants and document the public MQL4 constant style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
DateTimefactory construction so MetaEditor accepts the code path.DateTimeStructdate fields explicitly.TSHIELD_constants because MQL4 does not support namespaces and does not expose nested enum values asTimeShield::...members.MQL5/Include/TimeShield.mqhand removing the duplicateMQL5/Include/time_shield.mqhentry point.Validation
#include <TimeShield.mqh>smoke script — 0 errors, 0 warnings.MQL5/Scripts/time_shield/tests/test_eet_to_gmt.mq5— 0 errors, 7 warnings.MQL5/Scripts/time_shield/tests/test_time_zone_matrix.mq5— 0 errors, 7 warnings.MQL5/Scripts/time_shield/examples/time_conversions_demo.mq5— 0 errors, 8 warnings.MQL5/Scripts/time_shield/examples/time_formatting_demo.mq5— 0 errors, 7 warnings.MQL5/Scripts/time_shield/examples/time_parser_demo.mq5— 0 errors, 7 warnings.git diff --checkcmake --build tmp/agent-work/build-mql4 --parallel 36ctest --test-dir tmp/agent-work/build-mql4 --output-on-failureNotes
The MQL5 warnings are pre-existing import/type-conversion warnings and do not block code generation.