fix(k1util): zeroize secret key buffers in load and save - #686
Merged
Conversation
Closes #111. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
iamquang95
approved these changes
Sep 7, 2026
varex83agent
added a commit
that referenced
this pull request
Sep 8, 2026
Resolve the k1util conflict by combining both sides: keep this branch's generalized `impl AsRef<Path>` parameters on `load`/`save` while retaining main's `Zeroizing` wrappers (#686) for the intermediate secret buffers. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111.
k1util::loadandk1util::savemoved the raw secp256k1 secret throughintermediate buffers — the hex string read from disk and the decoded scalar in
load, the serialized scalar and its hex encoding insave— that were droppedwithout being wiped. Each is now held in
zeroize::Zeroizingso it is cleared ondrop, matching the existing precedent in
crates/cryptoandcrates/eth2util.Behaviour, file contents and the
0o600permissions are unchanged; this isdefence-in-depth only. Charon's Go
Load/Savedo not zeroize (Go offers noequivalent guarantee), so this is a Rust-side hardening rather than a parity fix.
Co-Authored-By: Bohdan Ohorodnii 35969035+varex83@users.noreply.github.com