refactor: replaced string-typed file to paths#287
Merged
Conversation
iamquang95
reviewed
Mar 17, 2026
crates/eth2util/src/keystore/load.rs
Outdated
| .map(|(i, (filepath, private_key))| KeyFile { | ||
| private_key, | ||
| filename, | ||
| filename: filepath.to_string_lossy().to_string(), |
Collaborator
There was a problem hiding this comment.
Should we store Path in KeyFile instead of String?
Collaborator
Author
There was a problem hiding this comment.
i was stuck between using String and PathBuf, because of having to use the to_string_lossy in the errors where the filename is used, and also because it needs a separate .display, but PathBuf makes more sense, as the KeyFile construction gets simpler and is the correct type. Going with PathBuf
iamquang95
approved these changes
Mar 17, 2026
Collaborator
iamquang95
left a comment
iamquang95
left a comment
There was a problem hiding this comment.
Please fix the lint check
emlautarom1
approved these changes
Mar 18, 2026
| .join("src/keystore/testdata") | ||
| .to_string_lossy() | ||
| .to_string(); | ||
| let testdata_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("src/keystore/testdata"); |
Collaborator
There was a problem hiding this comment.
I think it's safe to use "src/keystore/testdata" as literal, but for safety prefer chaining .join calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283