feature/CSTACKEX-65: Aggregate selection logic for creating ONTAP Volume in StoragePool creation workflow #24
Conversation
…NTAP Volume creation
sandeeplocharla
requested review from
piyush5netapp,
rajiv-jain-netapp and
suryag1201
| throw new CloudRuntimeException("No aggregates are assigned to SVM " + svmName); | ||
| } | ||
| // Set the aggregates which are according to the storage requirements | ||
| int maxAvailableAggregateSpace = storage.getSize().intValue(); |
There was a problem hiding this comment.
Since size isn’t assigned before connect executes, the process cannot succeed.
There was a problem hiding this comment.
Storage is already assigned but the other comment makes sense, aggregate selection should be in Volume creation code. So, have modified the code accordingly
There was a problem hiding this comment.
Let’s go over the code in the scrum meeting. My review was limited to the merged changes and the code review raised, so I’d appreciate your input on the code as it appears in your IDE.
| // Set the aggregates which are according to the storage requirements | ||
| int maxAvailableAggregateSpace = storage.getSize().intValue(); | ||
| Aggregate aggrChosen = null; | ||
| for (Aggregate aggr : aggrs) { |
There was a problem hiding this comment.
Why does the connect method handle aggregate selection? This logic should ideally reside in the volume creation process.
| } | ||
| // TODO: Implement logic to select appropriate aggregate based on storage requirements | ||
|
|
||
| List<Aggregate> aggrs = svm.getAggregates(); |
There was a problem hiding this comment.
Let’s test both scenarios: a direct SVM case and an SVM onboarded with cluster credentials. In the latter, the SVM may not have aggregates explicitly assigned but should still be able to access available aggregates within the cluster.
Description
This PR...
Has changes to choose an aggregate based on the max available space while creating ontap volume for Primary StoragePool creation.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Test-1: With Default aggregate sizes in 2vSim ONTAP Cluster
Test-2: After expanding one aggr's size