Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR restructures the EC2 Linux user-data iSCSI provisioning script to support multiple Linux distributions while staying within the 16KB EC2 user-data limit by embedding a compressed “real” script.
Changes:
- Added
linux_userData_real.shwith distro detection (RHEL-like vs Debian-like) and package install logic. - Replaced
linux_userData.shwith a small bootstrap wrapper that expands and runs the compressed real script. - Updated documentation and CloudFormation metadata to reflect the new workflow and supported distributions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData_real.sh |
New full user-data implementation with distro support and iSCSI/multipath provisioning. |
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData.sh |
Bootstrapper that exports parameters, decodes/decompresses, and executes the real script. |
Management-Utilities/ec2-user-data-iscsi-create-and-mount/build_linux_userData |
Build helper to regenerate the compressed linux_userData.sh wrapper from the real script. |
Management-Utilities/ec2-user-data-iscsi-create-and-mount/README.md |
Updated setup/deployment guidance and notes about the compressed Linux script. |
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml |
Small UX/parameter text updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData.sh
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData_real.sh
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/README.md
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/build_linux_userData
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData_real.sh
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData_real.sh
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/README.md
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/README.md
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/README.md
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/linux_userData_real.sh
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.