Skip to content

fix(runtime): read the nsbundle_pack sealing key from NS_BUNDLE_KEY_HEX - #47

Merged
triniwiz merged 1 commit into
mainfrom
fix/nsbundle-pack-key-env
Nov 7, 2026
Merged

triniwiz merged 1 commit into
mainfrom
fix/nsbundle-pack-key-env

Conversation

@triniwiz

@triniwiz triniwiz commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

nsbundle_pack only accepts the source-protection key as --key-hex <64 hex>. A process's command line is visible to other processes and is recorded by process-creation auditing (Event 4688, Sysmon, Defender), so the key ends up in logs.

This adds NS_BUNDLE_KEY_HEX as another way to pass the key:

  • used when neither --key-hex nor --write-key is given; an empty value is ignored
  • --key-hex and --write-key behave exactly as before
  • --help mentions the variable, so callers can detect support

The NativeScript CLI checks nsbundle_pack --help for NS_BUNDLE_KEY_HEX. It passes the key through the environment when the tool supports it and falls back to --key-hex otherwise, so the CLI and the runtime can be updated in either order.

Command lines show up in process lists and in process-creation audit
logs. --key-hex keeps working for CLIs that pass it.
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 69ed7f02-d641-4e50-bc21-9abc2872c3d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@triniwiz
triniwiz merged commit e9f828a into main Nov 7, 2026
3 checks passed
@triniwiz
triniwiz deleted the fix/nsbundle-pack-key-env branch November 7, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant