Skip to content

perf(android): create wrappers on the class prototype without a JSObject construction #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ammarahm-ed wants to merge 1 commit into from
Open

perf(android): create wrappers on the class prototype without a JSObject construction #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions NativeScript/ffi/jni/jsi/metadata/MetadataNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,9 @@ JsValue MetadataNode::CreateJSWrapper(JsRuntime &rt, ObjectManager *objectManage
return CreateArrayWrapper(rt);
}

JsValue obj = objectManager->GetEmptyObject();
JsObject plain(rt);
JsValue obj(rt, plain);
JsValue ctorFunc = GetConstructorFunction(rt);
auto object = obj.asObjectBorrowed(rt);
object.setProperty(rt, "constructor", ctorFunc);
js_util::setPrototypeOf(rt, obj, js_util::get_prototype(rt, ctorFunc));
SetInstanceMetadata(rt, obj, this);

Expand Down
5 changes: 3 additions & 2 deletions NativeScript/ffi/jni/napi/metadata/MetadataNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,10 @@ napi_value MetadataNode::CreateJSWrapper(napi_env env, ObjectManager *objectMana
if (m_isArray) {
obj = CreateArrayWrapper(env);
} else {
obj = objectManager->GetEmptyObject();
NAPI_GUARD(napi_create_object(env, &obj)) {
return nullptr;
}
napi_value ctorFunc = GetConstructorFunction(env);
NAPI_GUARD(napi_set_named_property(env, obj, CONSTRUCTOR, ctorFunc)) {}
napi_util::setPrototypeOf(env, obj, napi_util::get_prototype(env, ctorFunc));
SetInstanceMetadata(env, obj, this);
}
Expand Down
Loading