Skip to content

fix(runtime): resolve system symbols when an iOS app runs on a Mac #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runtime): resolve system symbols when an iOS app runs on a Mac #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions NativeScript/runtime/SymbolLoader.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,23 @@ virtual bool load() override {
}

void* SymbolLoader::loadFunctionSymbol(const ModuleMeta* module, const char* symbolName) {
// An iOS app on a Mac opens /System/Library/Frameworks bundles that do not carry
// the iOS symbols (those live under /System/iOSSupport), so a miss falls through
// to the process-wide lookup. Applies to loadDataSymbol too.
if (auto resolver = this->resolveModule(module)) {
return resolver->loadFunctionSymbol(symbolName);
if (void* symbol = resolver->loadFunctionSymbol(symbolName)) {
return symbol;
}
}

return dlsym(RTLD_DEFAULT, symbolName);
}

void* SymbolLoader::loadDataSymbol(const ModuleMeta* module, const char* symbolName) {
if (auto resolver = this->resolveModule(module)) {
return resolver->loadDataSymbol(symbolName);
if (void* symbol = resolver->loadDataSymbol(symbolName)) {
return symbol;
}
}

return dlsym(RTLD_DEFAULT, symbolName);
Expand Down
Loading