Skip to content

fix: close the inspector client socket on disconnect #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-niculescu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close the inspector client socket on disconnect #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions NativeScript/inspector/InspectorServer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
dispatch_io_t channel =
dispatch_io_create(DISPATCH_IO_STREAM, clientSocket, q, ^(int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
NSLog(@"InspectorServer channel cleanup error: %s", strerror(error));
}
close(clientSocket);
});
Expand All @@ -56,11 +56,12 @@

__block dispatch_io_handler_t receiver = ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
NSLog(@"InspectorServer read message header error: %s", strerror(error));
}

const void* bytes = [(NSData*)data bytes];
if (!bytes) {
dispatch_io_close(channel, DISPATCH_IO_STOP);
return;
}

Expand All @@ -73,7 +74,7 @@
dispatch_io_read(channel, 0, length, q, ^(bool done, dispatch_data_t data, int error) {
BOOL close = NO;
if (error) {
NSLog(@"Error: %s", strerror(error));
NSLog(@"InspectorServer read message body error: %s", strerror(error));
close = YES;
}

Expand Down Expand Up @@ -102,7 +103,7 @@
dispatch_io_read(channel, 0, 4, q, receiver);
}
} else {
NSLog(@"accept() failed;\n");
NSLog(@"InspectorServer accept() failed");
}
}
});
Expand Down Expand Up @@ -143,7 +144,7 @@

dispatch_io_write(channel, 0, data, queue, ^(bool done, dispatch_data_t data, int error) {
if (error) {
NSLog(@"Error: %s", strerror(error));
NSLog(@"InspectorServer::Send error: %s", strerror(error));
}
});
}
Expand Down
Loading