Repository navigation
Add Saved as a main tab - #5
Merged
Merged
Conversation
The Saved tab lists the commits you saved, last saved first, in the Log's rows, as the web's Saved page does. It has the web's "Only you" line, end line and empty state. Explore Trending opens the Log on Trending. Unsaving a commit there takes its row away once devnull says so. Saving or unsaving anywhere else patches the kept first page, so the change shows the next time Saved opens. Commits unsaved on this phone are remembered too, so rows on later pages go when you come back to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hairline under the description was a list row of its own, and iOS laid it out far taller than 1pt, which left a big gap above and below it. It now sits in the description's row, so the spacing matches the web's Saved page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Save and Unsave are in a commit's More menu now, so the Saved tests tap its items. Unsaving from the menu still takes the row away, and deleting your own saved commit from it lets the row go. The quote and report sheets draw their button in your lane colour, so Saved hands the view $myColour like the other screens. Without it, quoting or reporting from Saved failed to render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
force-pushed
the
feat/saved-tab
branch
from
October 18, 2026 18:48
3fd4022 to
59b2407
Compare
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Saved as a main tab, between Notifications and Profile, copying the web's
/savedpage.What changed
TabsLayout::Tabshas/saved, so commits and profiles opened from it push onto the Saved tab like the other tabs.Savedscreen at/saved, readingGET /api/v1/saved(already onfeat/mobile-api-reactions, no API changes). It uses the Log's rows (ShowsCommits,ExpandsThreads, the feed partial), last saved first, with day markers as the web's CommitFeed draws them. Above the list are the web's "Only you" line, with a newlock-keyholeicon from lucide-react 1.57.0, and its description. The end line and the empty state are the web's. Explore Trending switches to the Log tab, open on Trending.Client::bookmark()andunbookmark()now also patch the keptsavedpage (ResponseCache::commitSaved()). A save puts the commit on top and an unsave takes it out. A tab tap mounts the screen afresh, so the change is there the moment you open Saved. Stars leave the saved list alone, even though their answer carriesis_saved.unsavedIds(), likedeletedIds()). Coming back to Saved from a commit page drops those rows, even from pages loaded past the first.empty.blade.phptakes an optional link line.What to check
Saved::takeFresh()doesn't useFreshPage. Saved is ordered by when you saved, and saving again moves a commit to the top, so FreshPage's "newer commits wait in the pill" doesn't fit. A fresh page replaces the top of the list and the pages loaded below it stay, matched from the last commit the fresh page shares with the list. A page with no next cursor is the whole list.$forceFullFrameslike Log and Notifications, since rows leave from the middle.TabsLayout,routes/mobile.phporResponseCache::Cacheable.How it was verified
php artisan test: 706 passed after the rebase. Pint is clean.On an iPhone 17 Pro simulator (iOS 27.0) against
mobile-api-integration, signed in as local_dev:Frames from the pull to refresh recording: the list drags down, the spinner holds, and the commit saved on the server lands on top.
Opening a commit from Saved slides it in on the Saved tab. On the iPhone SE (375pt wide) all four labels fit, Notifications included. Android wasn't run; its Material bar has the same four items.
After phone testing, 3fd4022 tightens the space under the description. The hairline under it was a list row of its own, which iOS laid out far taller than 1pt, so it now sits in the description's row and the gaps match the web (after).
Rebased onto main after #3, #4, #7, #8 and #9 (59b2407). Save and Unsave now live in the commit's More menu, so the tests tap its items. Unsaving from the menu on Saved still removes the row, and deleting your own saved commit from it removes the row too. Saved now passes
$myColourto its view, without which the quote and report sheets failed to render there. Checked again on a fresh simulator: saved from the Log's menu, unsaved from Saved's menu (after), and deleted from Saved.The screenshots live on the orphan branch
saved-tab-screenshots, which can go once this merges.🤖 Generated with Claude Code