feat: implement PLEXOS solution reader and setup master files for 9-12 versions#141
Open
mcllerena wants to merge 37 commits into
Open
feat: implement PLEXOS solution reader and setup master files for 9-12 versions#141mcllerena wants to merge 37 commits into
mcllerena wants to merge 37 commits into
Conversation
added 10 commits
May 19, 2026 21:30
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 95.93% 96.16% +0.22%
==========================================
Files 8 17 +9
Lines 1919 2736 +817
==========================================
+ Hits 1841 2631 +790
- Misses 78 105 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: mcllerena <140716266+mcllerena@users.noreply.github.com>
… handling Agent-Logs-Url: https://github.com/NatLabRockies/plexosdb/sessions/c6e3393d-83d1-4487-8988-5a49be718e06 Co-authored-by: mcllerena <140716266+mcllerena@users.noreply.github.com>
Merge conflicts have been resolved in commit The key resolutions were:
All 892 tests pass. |
pesap
reviewed
Jun 22, 2026
pesap
left a comment
pesap
left a comment
Collaborator
There was a problem hiding this comment.
Two notes could not be attached inline because GitHub reports the XML diffs are too large for inline review comments:
src/plexosdb/config/master_9.2R6_btu.xmlhas trailing whitespace/line-ending noise from the first line onward. Please normalize the generated template files, or explicitly exclude them from the whitespace check if preserving source formatting is intentional.- The raw
src/plexosdb/config/master_*.xmltemplates add roughly 28 MB / 820k lines of package data. Since runtime loads them throughimportlib.resources, please verify the built wheel/sdist includes them intentionally and that the package-size increase is acceptable.
mcllerena
commented
Jul 6, 2026
|
|
||
| ```python | ||
| relation = sol.read_result( | ||
| generation, |
Contributor
Author
There was a problem hiding this comment.
The read_result() method does not exist, I think the method is called get_result(). We should update it in every use.
mcllerena
commented
Jul 6, 2026
|
|
||
| ```python | ||
| from plexosdb.db_solution_models import ResultPeriod, ResultPhase | ||
| from plexosdb.db_solution_models import PeriodEnum, PhaseEnum |
Contributor
Author
There was a problem hiding this comment.
Aren't these two coming from enums instead of db_solution_models?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.