Skip to content

V26.2.0-IOFreeze: ScheduleYearRules - #5644

Draft
joseph-robertson wants to merge 5 commits into
developfrom
v26.2.0-IOFreeze-ScheduleYearRules
Draft

V26.2.0-IOFreeze: ScheduleYearRules#5644
joseph-robertson wants to merge 5 commits into
developfrom
v26.2.0-IOFreeze-ScheduleYearRules

Conversation

@joseph-robertson

Copy link
Copy Markdown
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Aug 26, 2026
@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Aug 26, 2026
Base automatically changed from v26.2.0-IOFreeze to develop August 26, 2026 20:26
@jmarrec

jmarrec commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

@joseph-robertson I recommend you rebase this branch onto develop now that I merged

From command line, if v26.2.0-IOFreeze-ScheduleYearRules is checked out

git fetch origin
git rebase origin/develop

then git push --force

(it's also doable via the github UI as "Update with rebase" and in your favorite git client)

image

@joseph-robertson
joseph-robertson force-pushed the v26.2.0-IOFreeze-ScheduleYearRules branch from d3b6407 to 38694d8 Compare August 26, 2026 20:59
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 0
Passed 0
Failed 0
Errors 0
Skipped 0
Success Rate 0.0%
Generated 2026-08-27 21:00:44 UTC

❌ Significant Test Failures

📊 Test Run Information

Run XML File Status
- No XML files found ❌ Missing

Comment thread src/energyplus/Test/ScheduleRuleset_GTest.cpp Outdated
Comment thread src/energyplus/Test/ScheduleRuleset_GTest.cpp Outdated
Comment thread src/energyplus/ForwardTranslator/ForwardTranslateScheduleRuleset.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants