Skip to content

Add wrapper for submitting AWS Batch jobs - #85

Open
aaronfriedman6 wants to merge 1 commit into
mainfrom
add-batch-client
Open

aaronfriedman6 wants to merge 1 commit into
mainfrom
add-batch-client

Conversation

@aaronfriedman6

Copy link
Copy Markdown
Contributor

This is a wrapper that handles logging and error handling for calling submit_job on a boto3 Batch client

Comment on lines +26 to +27
def close(self):
self.batch_client.close()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only thing needed for cleanup? Do you have to disable the job queue or terminate any jobs before exiting?

@fatimarahman fatimarahman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants