Merged
Conversation
danamansana
requested review from
charmingduchess,
nonword and
yossariano
and removed request for
charmingduchess
nonword
reviewed
Feb 27, 2026
| } | ||
|
|
||
| module.exports = { simplify, reverseAST, reverseGrammar, parseRight, parseWithRightCql } | ||
| function display (ast) { |
Member
There was a problem hiding this comment.
What does this expect and what does it return? I'm not sure that "display" conveys it.
| } | ||
|
|
||
| function displayParsed (string) { | ||
| const parsed = rightCqlParser.getAST(reverseString(string)) |
Member
There was a problem hiding this comment.
Is there a way to better ensure that the chain of calls you're making to parse the string in this case matches the chain of calls in parseWithRightCql?
| return query | ||
| } | ||
| const request = ApiRequest.fromParams(params) | ||
| console.log('request: ', request) |
| const queryJson = ElasticQueryBuilder.forApiRequest(request).query.toJson() | ||
| if (queryJson.bool && queryJson.bool.filter) { | ||
| return { filter: queryJson.bool.filter } | ||
| } |
Member
There was a problem hiding this comment.
I assume this is a temporary measure until we can migrate the filter stuff into something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some further NYQL features as specified in SCC-5171 and SCC-5203:
also adds: