Merged
Conversation
Member
Author
|
@jwaldrop107 can you up the CI's CXX_STANDARD to 20 please? |
Member
|
Working on updating the test image. This is probably the time to remove the CXX_STANDARD from the toolchains and start specifying it in the individual libraries' |
jwaldrop107
reviewed
Nov 21, 2025
Member
jwaldrop107
left a comment
jwaldrop107
left a comment
There was a problem hiding this comment.
@ryanmrichard Here's a couple of smaller things. The only one I'd be specifically worried about is the cuda_tensor.cpp one with the brace and conditionals. Do you know if these changes work with the rest of the stack?
…or.cpp Co-authored-by: Jonathan M. Waldrop <relik107@gmail.com>
Contributor
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
Starts the refactoring necessary to get WTF integrated into TensorWrapper. This process quickly got away from me so I want to check-in an intermediate before continuing. This PR will:
MDBuffermeant to eventually becomeContiguous. What was the Eigen buffer will be deleted (it's now in the backend).N.b., all of the original classes are being left alone so this PR shouldn't break anything...
TODOs