Skip to content

Use 'nwx_find_package' wrapper find MPI #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zachcran wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use 'nwx_find_package' wrapper find MPI #157

zachcran wants to merge 2 commits into from

Conversation

@zachcran
Copy link
Contributor

@zachcran zachcran commented Dec 15, 2025 •
edited
Loading

Description

This PR utilizes the find_package wrappers added by NWChemEx/NWXCMake#59 to find MPI's MPI::MPI_CXX target.

TODOs

  • Verify that it works when built independently
  • Verify that it works when built in Spack

@zachcran zachcran self-assigned this Dec 15, 2025
@zachcran
Copy link
Contributor Author

zachcran commented Jan 28, 2026

Checks can't pass until NWChemEx/NWXCMake#59 is merged.

@zachcran zachcran marked this pull request as ready for review January 28, 2026 19:04
jwaldrop107
jwaldrop107 previously approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwaldrop107 jwaldrop107 jwaldrop107 approved these changes

@ryanmrichard ryanmrichard Awaiting requested review from ryanmrichard

At least 2 approving reviews are required to merge this pull request.

Assignees

@zachcran zachcran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zachcran @jwaldrop107