Repository navigation
Conversation
…llocator is passed [task.promise] specifies the promise's operator new(size_t) as operator new(size, allocator_arg, allocator_type()), both before and after P3980R1. The implementation passed std::allocator<std::byte> instead, so an environment's allocator_type was only used for the frame when the coroutine took an allocator_arg parameter.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[task.promise] specifies the promise's
operator new(size_t)asreturn operator new(size, allocator_arg, allocator_type());. That holds both before and after P3980R1 (applied to the working draft in cplusplus/draft#8918).taskpassedstd::allocator<std::byte>{}instead, so an environment'sallocator_typewas only used for the coroutine frame when the coroutine took anallocator_argparameter.Environments without an
allocator_typeare unaffected, since it defaults tostd::allocator<std::byte>. An environment whoseallocator_typeis not default-constructible now requires anallocator_argparameter, as the wording does; before, such a task compiled and silently usedstd::allocator.The new test uses a default-constructible counting allocator to check that the frame is allocated and freed through it.