Skip to content

Make get_completion_signatures align with the standard - #2228

Open
yulin25 wants to merge 1 commit into
NVIDIA:mainfrom
yulin25:fix/compsigs
Open

Make get_completion_signatures align with the standard#2228
yulin25 wants to merge 1 commit into
NVIDIA:mainfrom
yulin25:fix/compsigs

Conversation

@yulin25

@yulin25 yulin25 commented Aug 25, 2026

Copy link
Copy Markdown

According to the standard, STDEXEC::get_completion_signatures shall have only one constraint: environment count <= 1.
When the customization does not exist or the member get_completion_signatures customization is ill‑formed upon instantiation, STDEXEC::get_completion_signatures should throw an exception, while the invocation of STDEXEC::get_completion_signatures remains well-formed.
The internal STDEXEC::__compsigs::__get_completion_signatures_helper already does what the standard says, but STDEXEC::get_completion_signatures adds additional constraints, which does not align with the standard.
This PR removes those additional constraints.

@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant