Make get_completion_signatures align with the standard - #2228
Open
yulin25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the standard,
STDEXEC::get_completion_signaturesshall have only one constraint: environment count <= 1.When the customization does not exist or the member
get_completion_signaturescustomization is ill‑formed upon instantiation,STDEXEC::get_completion_signaturesshould throw an exception, while the invocation ofSTDEXEC::get_completion_signaturesremains well-formed.The internal
STDEXEC::__compsigs::__get_completion_signatures_helperalready does what the standard says, butSTDEXEC::get_completion_signaturesadds additional constraints, which does not align with the standard.This PR removes those additional constraints.