Skip to content

2091 compilation failed with fno exception#2092

Open
BartolomeyKant wants to merge 3 commits into
NVIDIA:mainfrom
aethernetio:2091-compilation-failed-with-fno-exception
Open

2091 compilation failed with fno exception#2092
BartolomeyKant wants to merge 3 commits into
NVIDIA:mainfrom
aethernetio:2091-compilation-failed-with-fno-exception

Conversation

@BartolomeyKant
Copy link
Copy Markdown
Contributor

solves #2091

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Copy Markdown
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually have any authority here, but I'd prefer to see the changes made slightly narrower.

}
}

#if !STDEXEC_NO_STDCPP_EXCEPTIONS()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this choice of scope excludes too many tests; I think it's only the scenarios that say throw that cause problems for -fno-exceptions builds. I'd prefer to have the other tests run in the no-exceptions build by narrowing the scope of this #if to only exclude the problematic scenarios.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean exclude only throwing sections here and keep the "int() noexcept from just(42)" ?

@ericniebler
Copy link
Copy Markdown
Collaborator

/ok to test 3f26d49

@BartolomeyKant
Copy link
Copy Markdown
Contributor Author

There is problems form Catch I forgot about. In local build I just remove Werror temporally.

/home/coder/stdexec/build/_deps/catch2-src/src/catch2/../catch2/catch_translate_exception.hpp:32:73: warning: unused parameter 'it' [-Wunused-parameter]
   32 |             std::string translate( ExceptionTranslators::const_iterator it, ExceptionTranslators::const_iterator itEnd ) const override {
      |                                                                         ^
/home/coder/stdexec/build/_deps/catch2-src/src/catch2/../catch2/catch_translate_exception.hpp:32:114: warning: unused parameter 'itEnd' [-Wunused-parameter]
   32 |             std::string translate( ExceptionTranslators::const_iterator it, ExceptionTranslators::const_iterator itEnd ) const override {
      |                                                                                                                  ^
2 warnings generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants