Unset IsHibernate to avoid resume from GC6/S0ix suspend taking incorrect hibernation resume path #1199
Open
freenull wants to merge 1 commit into
Open
Unset IsHibernate to avoid resume from GC6/S0ix suspend taking incorrect hibernation resume path #1199freenull wants to merge 1 commit into
freenull wants to merge 1 commit into
Conversation
InHibernate status was not reset after resuming from hibernate. This is normally not an issue because any STANDBY PM action resets it, but the GC6 resume path used when S0ix is enabled does not. The flag is now reset after leaving hibernation.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With S0ix enabled and using the latest version 610.43.02, the following sequence:
Results in no video output and no backlight with spinning fans. Kernel logs reveal an assertion failure:
After many debug prints I have been able to pinpoint this down to
rm_power_managementpicking the wrong branch here during the final resume (RmPowerManagementinstead ofRmGcxPowerManagement). It turns out that the root cause isInHibernatenever getting reset after resuming from hibernation. Because the _RESUME action conditionally switches the path based onInHibernate, the correct GC6 path is used during suspend, but once resume is requested the driver attempts to resume from hibernation instead. I've added a single line to resetInHibernateback to false after resuming from hibernation and I can now successfully execute any mix of suspend and hibernate on my machine.This fixes Bug 5156763 based on my report on the NVIDIA forums from a while back. The proprietary driver used to dump the exact same assertion failure back when I was still using it, so I suspect the same patch should apply cleanly there as well :)