nvidia: suppress newline-only RM log output#1189
Open
francdoc wants to merge 1 commit into
Open
Conversation
out_string() forwards strings from RM directly to printk(). If RM emits a separator consisting only of a newline, this can create a blank kernel log record during boot. Ignore NULL, empty, and newline-only strings before calling printk() so separator-only output does not appear as a false boot error in journalctl -p3. Fixes NVIDIA#1098.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1098.
out_string() forwards strings from RM directly to printk(). If RM emits a separator consisting only of a newline, this can create a blank kernel log record during boot and appear in journalctl -p3 as a false error.
Ignore NULL, empty, and newline-only strings before calling printk(). Real log messages are still printed unchanged.
Although the visible symptom is a log artifact, this changes executable logging behavior by suppressing separator-only output before printk().
Validation:
Not performed: