Skip to content

Don't wake a runtime-suspended dGPU to service NVPCF/GPS ACPI notifies #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElXreno wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −5
Open

Don't wake a runtime-suspended dGPU to service NVPCF/GPS ACPI notifies #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/nvidia/arch/nvalloc/unix/src/osapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,6 +2023,17 @@ static void RmHandleGPSStatusChange
RM_API *pRmApi;
THREAD_STATE_NODE threadState;
NV0000_CTRL_SYSTEM_GPS_CONTROL_PARAMS gpsControl = { 0 };
nv_priv_t *nvp = NV_GET_NV_PRIV(pNv);

//
// Don't wake a runtime-suspended GPU just to handle a GPS status
// change; service it only when the GPU is already awake.
//
if (nvp != NULL &&
nvp->dynamic_power.state == NV_DYNAMIC_POWER_STATE_IDLE_INDICATED)
{
return;
}

pRmApi = RmUnixRmApiPrologue(pNv, &threadState, RM_LOCK_MODULES_ACPI);
if (pRmApi == NULL)
Expand Down Expand Up @@ -6066,13 +6077,23 @@ void NV_API_CALL rm_acpi_nvpcf_notify(
if (pGpu != NULL)
{
nv_state_t *nv = NV_GET_NV_STATE(pGpu);
if ((rmStatus = os_ref_dynamic_power(nv, NV_DYNAMIC_PM_FINE)) ==
NV_OK)
nv_priv_t *nvp = NV_GET_NV_PRIV(nv);

//
// Don't wake a runtime-suspended GPU just to deliver an NVPCF
// event; service it only when the GPU is already awake.
//
if (nvp == NULL ||
nvp->dynamic_power.state != NV_DYNAMIC_POWER_STATE_IDLE_INDICATED)
{
gpuNotifySubDeviceEvent(pGpu, NV2080_NOTIFIERS_NVPCF_EVENTS,
NULL, 0, 0, 0);
if ((rmStatus = os_ref_dynamic_power(nv, NV_DYNAMIC_PM_FINE)) ==
NV_OK)
{
gpuNotifySubDeviceEvent(pGpu, NV2080_NOTIFIERS_NVPCF_EVENTS,
NULL, 0, 0, 0);
}
os_unref_dynamic_power(nv, NV_DYNAMIC_PM_FINE);
}
os_unref_dynamic_power(nv, NV_DYNAMIC_PM_FINE);
}
rmapiLockRelease();
}
Expand Down