Skip to content

fix: Fix support for nvswitch mode#1661

Merged
elezar merged 2 commits intoNVIDIA:mainfrom
elezar:fix-nvswitch-support
Feb 18, 2026
Merged

fix: Fix support for nvswitch mode#1661
elezar merged 2 commits intoNVIDIA:mainfrom
elezar:fix-nvswitch-support

Conversation

@elezar
Copy link
Member

@elezar elezar commented Feb 17, 2026

Although the code paths exist to generate nvswitch CDI specs, the mode is not supported. This change adds a unit test for this use case and fixes the bug.

Before the change:

ERRO[0000] failed to generate CDI spec: failed to create CDI library: unknown mode "nvswitch"

With this change the generation succeeds (or fails on a system where there are no such devices).

@elezar elezar requested a review from jgehrcke February 17, 2026 14:39
@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Feb 17, 2026
@elezar elezar added this to the v1.19.0 milestone Feb 17, 2026
@coveralls
Copy link

coveralls commented Feb 17, 2026

Pull Request Test Coverage Report for Build 22132846524

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 39.128%

Totals Coverage Status
Change from base Build 22132826107: 0.2%
Covered Lines: 5724
Relevant Lines: 14629

💛 - Coveralls

@elezar elezar requested a review from cdesiniotis February 17, 2026 14:44
Copy link
Collaborator

@jgehrcke jgehrcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elezar elezar force-pushed the fix-nvswitch-support branch 4 times, most recently from 8da2088 to 5409364 Compare February 18, 2026 08:40
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the fix-nvswitch-support branch from 5409364 to 2b755ae Compare February 18, 2026 08:50
@elezar elezar merged commit 3358957 into NVIDIA:main Feb 18, 2026
16 checks passed
@elezar elezar deleted the fix-nvswitch-support branch February 18, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue/PR to expose/discuss/fix a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments