Load settings from config.toml file during CDI generation

[ArangoGutierrez]

This pull request adds logic for nvidia-ctk cdi generate to load settings from the config.toml file, the order of importance if (1) command line, (2) environment variable(for those flags with an ENV VAR option), (3) config file.

[no-relnote] extra: migrates to urfave v3

Fixes #1075

[Copilot]

Pull Request Overview

This pull request adds logic to load configuration from a config.toml file during CDI generation and listing, ensuring the proper order of precedence when determining settings (command line, environment variable, then config file).

• Introduces a MockLogger for internal logging tests
• Extends flag validation in the list and generate commands to incorporate config file values
• Updates tests to cover configuration loading and flag precedence

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
internal/logger/mock.go	Adds a mock logger implementation
cmd/nvidia-ctk/cdi/list/list_test.go	Adds tests for flag precedence in the list cmd
cmd/nvidia-ctk/cdi/list/list.go	Implements loading config file for list command
cmd/nvidia-ctk/cdi/generate/generate_test.go	Adds tests for config loading in generate command
cmd/nvidia-ctk/cdi/generate/generate.go	Integrates config file values into generate flags

[ArangoGutierrez]

Let's first agree on #1123 , I'll then rebase this PR and continnue the work here

[ArangoGutierrez]

PR updated now with a centralized logic at /internal/config
PTAL @elezar

[coveralls]

Pull Request Test Coverage Report for Build 15447921501

Details

• 107 of 125 (85.6%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.9%) to 34.12%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/nvidia-ctk/cdi/generate/generate.go	12	14	85.71%
cmd/nvidia-ctk/cdi/list/list.go	10	12	83.33%
internal/config/flags.go	85	99	85.86%

Totals
Change from base Build 15437228265:	0.9%
Covered Lines:	4365
Relevant Lines:	12793

---

💛 - Coveralls

[ArangoGutierrez]

With #763 in I would like this PR to go next
cc @elezar

[elezar]

Do you have a reference for this change?

[ArangoGutierrez]

moving all the c.something into the c:= cli.Command initialization

[elezar]

Nit: This functionality is new.

[elezar]

Please don't pass nil into the run() function. This also doesn't seem to be related to adding a config file.

[elezar]

The last commit has more changes than I would expect -- which I would expect to be limited to the generate.go and up the chain to nvidia-ctk main.go.

[Copilot]

Pull Request Overview

This PR migrates the CLI to urfave/cli v3, adds a --config flag and config-file support for loading settings (command line, env, config.toml precedence), and updates the generate command to pull default values from a TOML config.

• Bump Go version and replace urfave/cli/v2 imports with urfave/cli/v3 and add cli-altsrc/v3
• Introduce configAsValueSource to allow flags to be loaded from config.toml in cdi generate
• Update all subcommands to use Sources: cli.EnvVars and the new context-based Before/Action signatures

Reviewed Changes

Copilot reviewed 35 out of 159 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
go.mod	Updated Go version, added toolchain, switched CLI deps
cmd/nvidia-ctk/main.go	Converted root CLI to v3, added global --config flag
cmd/nvidia-ctk/config/create-default/create-default.go	Migrated to v3 but removed validation call
cmd/nvidia-ctk/cdi/generate/config.go	Added configAsValueSource for TOML-backed flag sources
cmd/nvidia-ctk/system/system.go	Added unused configFile field in system commands
many others	Updated Before/Action signatures, replaced EnvVars

Comments suppressed due to low confidence (2)

cmd/nvidia-ctk/cdi/generate/config.go:31

• [nitpick] Consider adding unit tests for configAsValueSource (e.g., From, loadIfRequired, ValueSource.Lookup) to verify configuration flags are correctly loaded from TOML files.

func (o *options) Config() *configAsValueSource {

cmd/nvidia-ctk/config/create-default/create-default.go:71

• This validateFlags implementation always returns nil, disabling the previous opts.Validate() logic. Restore a call to opts.Validate() or add equivalent checks to ensure flags are valid.

func (m command) validateFlags(c *cli.Command, opts *flags.Options) error {

[elezar]

I think the migration to v3 will be valuable for some of our other projects too -- although this is not critical.