chore: migrate nvsnap and nvcf-unbound golangci-lint configs to v2#228
Open
mesutoezdil wants to merge 2 commits into
Open
chore: migrate nvsnap and nvcf-unbound golangci-lint configs to v2#228mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
Both .golangci.yml files were still in v1 schema (no version field, linters-settings, exclude-dirs, exclude-rules). golangci-lint v2 rejects them outright with "unsupported version of the configuration", so linting has not been running for either module. Migrated both with the official `golangci-lint migrate` command, then hand-restored the explanatory comments it drops, in particular the gosec exclude rationale in nvsnap (world-readable cache dirs needed for cross-uid pod restore). Verified both configs load with `golangci-lint config verify` and `golangci-lint run` now executes instead of failing immediately. nvsnap is Linux-only and does not type-check on this darwin host, so also cross-compiled with GOOS=linux to confirm the lint pass itself runs end to end (358 pre-existing findings surfaced, out of scope for this change). NO-REF Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
📝 WalkthroughWalkthroughBoth Go services migrate their golangci-lint configurations to version 2. The changes restructure linter settings, revise enabled linters and exclusions, and configure formatter handling separately. Changesgolangci-lint configuration migration
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvsnap and nvcf-unbound .golangci.yml were still v1 schema; golangci-lint v2 failed to load them. Migrated both to v2 with the official migrate tool, restored comments it stripped.
Tested: golangci-lint config verify passes for both. golangci-lint run now executes (358 pre-existing findings surfaced, out of scope here).
Refs: NO-REF