chore(function-autoscaler): add TimeseriesDB mTLS support#215
Open
borao wants to merge 1 commit into
Open
Conversation
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
| Ok(base_url) | ||
| } | ||
|
|
||
| fn mtls_identity(config: &TimeseriesDbSettings, base_url: &Url) -> Result<Identity> { |
Contributor
There was a problem hiding this comment.
I assume the Identity secret is never rotating and we don't need to use SecretFileWatcher
dmikhaylovnv
approved these changes
Jul 17, 2026
dmikhaylovnv
left a comment
Contributor
There was a problem hiding this comment.
Over all LGTM, left minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds mTLS support for function autoscaler TimeseriesDB queries while preserving the existing token and local auth modes.
Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
auth_modesetting with legacydisable_authcompatibility.mtls./api/v1/query_rangepath for direct/local modes and keeps the legacy/v1/query_rangepath for token auth.For the Reviewer
timeseries_db_client.rsfor the client setup and request path behavior.effective_auth_mode.For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
cargo test -p rs-autoscalerResult: 116 passed, 0 failed, 11 ignored.
Issues
NO-REF
Checklist