chore(oss): add missing helm chart files#214
Conversation
22fff47 to
ee228b6
Compare
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-07-16 21:49:25 UTC | Commit: ee228b6 |
37b4cd2 to
67ab7ec
Compare
|
|
||
| # Deploying via Helm | ||
|
|
||
| ## SETUP |
There was a problem hiding this comment.
@sbaum1994, do we still need these instructions?
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -euo pipefail |
There was a problem hiding this comment.
Is this still be referenced/used anywhere?
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -euo pipefail |
There was a problem hiding this comment.
same with this - do we use it?
|
|
||
| --- | ||
|
|
||
| ## 1. Executive Summary |
There was a problem hiding this comment.
Is this still needed? @sbaum1994 is there a new place to put bug reports like this?
| @@ -0,0 +1,4 @@ | |||
| module signing-key-harness | |||
|
|
|||
There was a problem hiding this comment.
Should this whole module integrate with bazel?
86ecc74 to
70decc2
Compare
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-07-16 22:53:29 UTC | Commit: 70decc2 |
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-07-16 23:16:05 UTC | Commit: 70decc2 |
97ee757 to
546083b
Compare
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-07-16 23:24:01 UTC | Commit: 546083b |
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-07-16 23:41:23 UTC | Commit: 546083b |
Add Helm chart files that were missing from the repository: build and test tooling (Makefiles, render tests), example values files, and the shared tools/ci/helm-validate-values CI values used by chart lint and render checks. Registry, host, and endpoint references in the added files use generic <your-registry>/<your-org>/<your-otel-endpoint> placeholders, matching the convention in the existing chart READMEs. The image registry examples in the openbao and cassandra READMEs are generalized the same way. Not added: per-chart license-header tooling (apply/check scripts, .license-header.txt, and the Makefile license-header targets), CODEOWNERS files, chart AGENTS.md/CLAUDE.md pairs, vendored subchart .tgz binaries, internal CI automation (renovate.json), and internal runbooks/examples. Closes #218
546083b to
3869ce6
Compare
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3 participants
Why
Several Helm chart files were missing from the repository: build and test tooling (Makefiles, license-header scripts, render tests), example values files, and the shared CI values used by chart lint and render checks. This adds them so the charts are complete and their tests are runnable.
What changed
Add the missing files across the deploy/helm charts, plus tools/ci/helm-validate-values. Registry, host, and endpoint references in the added files use generic // placeholders, matching the convention in the existing chart READMEs.
Chart AGENTS.md and CLAUDE.md files are out of scope here; they reference paths not yet present in the repository and land in a later change.
Testing
Chart lint and render values are included so the existing CI checks exercise the added files. SPDX license headers are present on added source files.
References
Closes #218