feat(nvca): nvsnap GPU checkpoint/restore integration#208
Draft
balajinvda wants to merge 1 commit into
Draft
Conversation
Port the nvsnap checkpoint/restore integration into the nvca operator (re-port of GitLab !651 / closed !1748) onto post-cutover GitHub main. - nvca operator drives nvsnap GPU checkpoint/restore (pkg/nvca/nvsnap: controller + reconciler), wired into NVCAAgent reconcile. - serialized-herd cold start via pioneer election. - operator chart (deployment/values/networkpolicy) + feature flag. Applied as a net-diff onto github/main, whose history is disjoint from GitLab. 60 files; the GitLab CI config and byoc featureflags docs are dropped (absent on GitHub). Merge is clean: `go build ./...` is green, the new nvsnap packages pass, and there are no new test failures versus the github/main baseline. Co-Authored-By: Balaji Ganesan <bganesan@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Brings the nvsnap GPU checkpoint/restore integration into the nvca operator, so NVCA-managed function pods can drive checkpoint capture and fast restore. Moved here from the (now frozen) GitLab repo as part of the GitHub cutover.
What changed
pkg/nvca/nvsnap(controller + reconciler), wired into theNVCAAgentreconcile path.How this was ported
github/mainhas a history disjoint from the old GitLab branch, so this is applied as a net-diff ontogithub/main(3-way merge), not a rebase. The GitLab CI config and the byocfeatureflagsdocs are dropped (absent on GitHub / not applicable here).Testing
go build ./...on the nvca module: green.pkg/nvca/nvsnap,.../controller,.../reconciler): tests pass.github/mainbaseline (the pre-existing RBAC/network-policy golden-data test failures and the version-stamp init panic under plaingo testreproduce identically on unmodifiedgithub/main; the module is normally tested via Bazel with version stamping).Notes / follow-ups
BUILDregeneration to CI verification; the auto-merged generated files compile, will regenerate if CI flags staleness.Relates to #71