feat(byoo-otel-collector): expose collector config knobs#194
Open
kristinapathak wants to merge 2 commits into
Open
feat(byoo-otel-collector): expose collector config knobs#194kristinapathak wants to merge 2 commits into
kristinapathak wants to merge 2 commits into
Conversation
Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
Contributor
Author
|
CI note after migration:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Expose BYOO OTel collector runtime config as NVCA operator Helm values and pass it through agent config to the BYOO collector renderer.
Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
agent.byooOtelCollectorconfig for exporterhelper timeout/retry/sending_queue, memory_limiter, batch, telemetry logs, and debug exporter fanout.BYOO_OTEL_COLLECTOR_CONFIG_B64for BYOO OTel collector pods while preserving the existing BYOO log chunking env vars.For the Reviewer
Start with
src/compute-plane-services/byoo-otel-collector/internal/otelconfig/collector_config.goandsrc/libraries/go/lib/pkg/types/nvca/config/types.go.For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
git diff --check origin/main..HEADgo test ./internal/otelconfiggo test ./pkg/types/nvca/configgo test -vet=off ./pkg/operator/reconcile -run TestEncodeAgentConfig_MergesBYOOConfig -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'go test -vet=off ./internal/miniservice -run TestReconcile_Function -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'go test -vet=off ./pkg/nvca -run '^$' -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'Issues
NO-REF
Checklist