Skip to content

feat(byoo-otel-collector): expose collector config knobs#194

Open
kristinapathak wants to merge 2 commits into
mainfrom
ci/byoo-otel-config-knobs
Open

feat(byoo-otel-collector): expose collector config knobs#194
kristinapathak wants to merge 2 commits into
mainfrom
ci/byoo-otel-config-knobs

Conversation

@kristinapathak

Copy link
Copy Markdown
Contributor

TL;DR

Expose BYOO OTel collector runtime config as NVCA operator Helm values and pass it through agent config to the BYOO collector renderer.

Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

  • Adds structured agent.byooOtelCollector config for exporterhelper timeout/retry/sending_queue, memory_limiter, batch, telemetry logs, and debug exporter fanout.
  • Encodes the merged config into BYOO_OTEL_COLLECTOR_CONFIG_B64 for BYOO OTel collector pods while preserving the existing BYOO log chunking env vars.
  • Updates source and vendored NVCA operator chart values, schema, and README entries.

For the Reviewer

Start with src/compute-plane-services/byoo-otel-collector/internal/otelconfig/collector_config.go and src/libraries/go/lib/pkg/types/nvca/config/types.go.

For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

  • git diff --check origin/main..HEAD
  • go test ./internal/otelconfig
  • go test ./pkg/types/nvca/config
  • go test -vet=off ./pkg/operator/reconcile -run TestEncodeAgentConfig_MergesBYOOConfig -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'
  • go test -vet=off ./internal/miniservice -run TestReconcile_Function -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'
  • go test -vet=off ./pkg/nvca -run '^$' -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0'

Issues

NO-REF

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
@kristinapathak
kristinapathak requested review from a team and along-2017 as code owners July 16, 2026 17:00
@kristinapathak

Copy link
Copy Markdown
Contributor Author

CI note after migration:

  • bazel (umbrella-phase1) fails before reaching this patch: current main has .bazelrc referencing tools/bazel/downloader.cfg, but that file is absent in the GitHub checkout. The latest main Bazel workflow at base SHA 44dfc09e66d4e4826800c4ef09160933d9eaa1db is also failing.
  • bazel (nvca) reaches Bazel analysis, then fails while querying the remote cache/execution endpoint: Failed to query remote execution capabilities: General OpenSslEngine problem.
  • Local focused validation on the migrated branch passed: git diff --check, BYOO go test ./internal/otelconfig, go-lib go test ./pkg/types/nvca/config, and focused NVCA reconcile/miniservice/pkg checks listed in the PR body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant