Fix: empty parameter error code for vpc peering endpoint #3771
Merged
SnobbishFish40 merged 3 commits intoJul 21, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe VPC peering handler consistently parses query parameters, returns 400 for invalid ChangesVPC peering query validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-21 10:50:21 UTC | Commit: da03ad6 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
rest-api/api/pkg/api/handler/vpcpeering_test.go (1)
515-521: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd regression cases for present-but-empty parameters.
This test covers malformed
siteId, but not the newsiteId=andisMultiTenant=behavior. Add both cases with expected HTTP 400 while retaining the existing omitted-parameter success coverage.Suggested test cases
+ { + name: "error when siteId is empty", + reqOrgName: tnOrg1, + queryString: "siteId=", + user: tnu1, + expectedStatus: http.StatusBadRequest, + }, + { + name: "error when isMultiTenant is empty", + reqOrgName: tnOrg1, + queryString: "isMultiTenant=", + user: tnu1, + expectedStatus: http.StatusBadRequest, + },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rest-api/api/pkg/api/handler/vpcpeering_test.go` around lines 515 - 521, Add regression cases alongside the existing invalid siteId case in the VPC peering handler tests for present-but-empty siteId and isMultiTenant query parameters, each expecting http.StatusBadRequest. Retain the existing omitted-parameter success coverage and use the same test table structure and symbols.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@rest-api/api/pkg/api/handler/vpcpeering_test.go`:
- Around line 515-521: Add regression cases alongside the existing invalid
siteId case in the VPC peering handler tests for present-but-empty siteId and
isMultiTenant query parameters, each expecting http.StatusBadRequest. Retain the
existing omitted-parameter success coverage and use the same test table
structure and symbols.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ff290370-cb5f-4405-8712-693ade6e8c33
📒 Files selected for processing (2)
rest-api/api/pkg/api/handler/vpcpeering.gorest-api/api/pkg/api/handler/vpcpeering_test.go
hwadekar-nv
approved these changes
Jul 21, 2026
hwadekar-nv
left a comment
hwadekar-nv
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GET /v2/org/{org}/forge/vpc-peering handled empty filter values inconsistently. The newer filters (status, vpcId, peerTenantId) rejected a present-but-blank value with 400, but the older siteId and isMultiTenant silently ignored a blank value and returned an unfiltered 200.
These changes make all five filters behave the same way.
Changes:
Related issues
#3770
Type of Change
Breaking Changes
Testing