ci: add floating latest tag for each release#3727
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughChangesThe CI workflow derives a major.minor version, exports conditional latest-tag outputs, and publishes major.minor-latest tags for primary containers, release images, platform images, and selected multi-architecture manifests. Versioned image tags
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Line 575: Guard the additional_tags values in all six base-container jobs,
including the entries near build_container_x86_64_version_latest, with the
release-publish predicate. Ensure each value is empty when tag_latest is
enabled, so pull-request and non-release builds cannot move floating
release-line tags.
- Line 702: Add matching major-minor “-latest” manifest tags to the imagetools
create calls in merge-manifests-nvmetal-carbide and
merge-manifests-machine-validation. Use the existing image registry and
major_minor_version outputs for both nvmetal-carbide and machine_validation,
while preserving their version tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 06f7607d-937f-4c27-91b3-5eaee1e3b899
📒 Files selected for processing (1)
.github/workflows/ci.yaml
This adds a floating
-latesttag for each release to make it easier to automate security scanning. Since this tag points to the latest of a given release, we can use themajorandminorof the given version to get the floating tag to update (ex:v2.0.0-rc.16->v2.0).This utilizes the
addtional_tagsinput for thedocker-buildworkflow call which can be used to add additional tags to upload a given container to the registry. For some of the build jobs we already publish alatestwhich is accounted for by setting the appropriate var to emptybuild_container_x86_64_version_latest=whichdocker-buildhandles to not adding any additional tags. For other jobs, justversionis used to upload which we can reuse the same<major>.<minor>-later.Related issues
Type of Change
Breaking Changes
Testing
Additional Notes