Skip to content

allow configuring leader-lease-renew-deadline - #2887

Merged
rahulait merged 1 commit into
NVIDIA:mainfrom
rahulait:configure-lease-renew-deadline
Sep 15, 2026
Merged

rahulait merged 1 commit into
NVIDIA:mainfrom
rahulait:configure-lease-renew-deadline

Conversation

@rahulait

@rahulait rahulait commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

We currently configure leader-lease-renew-deadline with installs using OLM bundle. This change allows us to configure the same with helm installs as well.

See #2767 (comment)

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 7731b840-8683-467f-8ca3-b86e88ed968f

📥 Commits

Reviewing files that changed from the base of the PR and between 9f85a2a and 0d25508.

📒 Files selected for processing (2)
  • deployments/gpu-operator/templates/operator.yaml
  • deployments/gpu-operator/values.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The GPU Operator Helm chart now documents an optional leader-election renewal deadline. When .Values.operator.leaderElection.renewDeadline is set, the operator Deployment template adds --leader-lease-renew-deadline with the configured value.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 0d255

The optional Helm setting is documented and rendered consistently without introducing a merge-blocking risk.


Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread deployments/gpu-operator/templates/operator.yaml
@rahulait rahulait self-assigned this Sep 15, 2026
@rahulait

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-26.7

@rahulait
rahulait merged commit 42f92e7 into NVIDIA:main Sep 15, 2026
21 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Backport PR created for release-26.7: #2902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants