Repository navigation
chore(core): cover joystick drag tracking - #484
Merged
Merged
Conversation
Adds a unit test that moves the pointer across the joystick surface before release. Line coverage for joystick.ts rises from 233/238 (97.89%) to 238/238 (100%), and branch coverage rises from 231/259 (89.18%) to 235/259 (90.73%). No behavior change. Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 1 most impacted file.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
coryrylan
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage for
projects/core/src/joystick/joystick.ts.Selector rationale: "5 uncovered lines, 97.89% lines and 89.18% branches, the smallest gap below the 90% threshold."
Measurement
The new test drags the pointer across the surface and checks the vector before release. That exercises the drag-gesture handler unit tests had not reached. No other file's coverage decreased.
No public API changed.
Left alone
The remaining 24 branches are defensive or uncommon paths: server-side value hydration, non-custom gesture events, gesture input that is not a matching pointer, a drag that is not the active pointer, keyboard input after a start listener clears the session, a visibility event while the document is shown, an absent value during a constraint change, non-string and empty form state, announcement and translation fallbacks, pointer-capture release, a zero-size travel box, a rejected pointer claim, keyboard movement from an absent value, an invalid keyboard step, arrow keys during a pointer drag, and the vertical axis lock.
Validation
projects/core: lint, test (2371 passed, 1 skipped), test:types, test:axe, test:ssr, test:lighthouse (84 passed), test:visualpnpm run cipassedgit diff --checkcleantest:types, test:axe, test:ssr, and test:visual were wireit cache hits. This change is limited to the unit test, and those tasks do not take that file as an input.