[mc8max]

This PR removes the stray > from ANN_BENCH_BUILD_MAIN in cpp/bench/ann/CMakeLists.txt.
This corrects the compile definition used when CUVS_ANN_BENCH_SINGLE_EXE is disabled.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuvs
• Branch: main
• File: .coderabbit.yaml
• Commit: 44df703
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 542bf7aa-ba84-4191-a918-13bac4e36af4

Commits

Reviewing files that changed from the base of the PR and between 44df703 and 8cfaa99.

Files selected for processing: 1

• cpp/bench/ann/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Summary

Summary by CodeRabbit

• Bug Fixes
  • Corrected the build configuration for ANN benchmarks, allowing the affected benchmark target to build as intended.

The non-single-executable ANN benchmark target’s compile definition changes from ANN_BENCH_BUILD_MAIN> to ANN_BENCH_BUILD_MAIN.

Changes: ANN benchmark build

Layer / File(s)	Summary
Correct benchmark compile definition cpp/bench/ann/CMakeLists.txt	The target’s compile definition no longer includes a trailing >.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: achirkin

Merge Risk: Minimal · up to 8cfaa

The compile-definition typo is fixed and the benchmark targets retain the expected macro contract.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description directly explains the removal of the stray > from ANN_BENCH_BUILD_MAIN and the resulting correction to the ANN benchmark compile definition.
Title check		The title clearly and concisely identifies the typo fix in the ANN benchmark main compile definition.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[mc8max]

Hi @achirkin, can you help review this PR please?

[achirkin]

/ok to test 5af07a3

[achirkin]

Hmm, not sure how come this was unnoticed for two years and still compiling

[achirkin]

Thanks for spotting this!

[achirkin]

/merge