-
Notifications
You must be signed in to change notification settings - Fork 143
update routing tests #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update routing tests #940
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
74c86ee
update routing tests
Iroy30 d09fae9
Merge branch 'main' into update_routing_tests
Iroy30 ac1f2c4
move solomon break testing to C++, add break validation in check_route
Iroy30 f80ffef
Merge branch 'main' into update_routing_tests
Iroy30 4a6e0f5
Merge remote-tracking branch 'iroy30/update_routing_tests'
Iroy30 e0a1931
Merge branch 'main' into update_routing_tests
Iroy30 1fb0a10
Update test_solver.py
Iroy30 0826f7d
Update breaks.cu
Iroy30 8612bbe
formatting
Iroy30 8b5914e
Merge remote-tracking branch 'iroy30/update_routing_tests'
Iroy30 4f6b141
formatting
Iroy30 5020a00
add missing import
Iroy30 ad9efbc
Merge branch 'main' into update_routing_tests
Iroy30 da6bd8c
Merge branch 'main' into update_routing_tests
Iroy30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 10389
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 4201
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 316
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 1023
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 4815
Critical use-after-free: device memory freed before solve accesses stored pointers.
Device copies
v_e,v_l,v_dare destroyed at the end of each loop iteration, butadd_break_dimensionstores raw pointers to this memory inbreak_dimensions_(line 146 ofdata_model_view.cu). Whensolveis called at line 94, these pointers become dangling references to freed device memory.All other tests in this file keep device memory alive until after
solvecompletes (e.g.,uniform_breaksat lines 42–47).🐛 Proposed fix: keep device memory alive until after solve
📝 Committable suggestion
🤖 Prompt for AI Agents