Skip to content

enforce 'yamllint' checks#1613

Open
jameslamb wants to merge 3 commits into
NVIDIA:mainfrom
jameslamb:yamllint
Open

enforce 'yamllint' checks#1613
jameslamb wants to merge 3 commits into
NVIDIA:mainfrom
jameslamb:yamllint

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Description

Proposes enforcing yamllint checks here. My primary motivation is to catch correctness issues in dependencies.yaml files, like duplicate entries silently resolving to the last one or indentation mistakes leading to filters being ignored.

But this also has some side benefits for consistency, which makes it a bit easier to write automation.

Issue

Contributes to rapidsai/build-planning#305

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
  • Documentation
    • The documentation is up to date with these changes

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 23, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

Comment thread codecov.yml
coverage:
status:
project: off
project: off # yamllint disable-line rule:truthy

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov's docs explicitly say to use off here: https://docs.codecov.com/docs/gitlab-4b-setting-coverage-standards-with-flags

Let's not touch it.

@jameslamb
jameslamb marked this pull request as ready for review July 23, 2026 20:58
@jameslamb
jameslamb requested review from a team as code owners July 23, 2026 20:58
@jameslamb jameslamb changed the title WIP: enforce 'yamllint' checks enforce 'yamllint' checks Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e452da30-fa2f-4187-b713-8937b2f369b0

📥 Commits

Reviewing files that changed from the base of the PR and between 42d3439 and 46c33bd.

📒 Files selected for processing (1)
  • .yamllint.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .yamllint.yaml

📝 Walkthrough

Walkthrough

Changes

YAML linting rollout

Layer / File(s) Summary
Define YAML lint policy and exemptions
.yamllint.yaml, .pre-commit-config.yaml, codecov.yml, cpp/src/grpc/codegen/field_registry.yaml
Adds yamllint rules and a pre-commit hook, with targeted exclusions and inline suppressions for existing YAML structures.
Route lint configuration changes in CI
.github/CODEOWNERS, .github/workflows/pr.yaml
Assigns ownership of .yamllint.yaml and excludes it from unrelated changed-file test groups.
Normalize repository YAML inputs
conda/recipes/*/recipe.yaml, dependencies.yaml, docs/cuopt/.../cuopt-nimservice-full.yaml
Updates YAML booleans, indentation, dependency declarations, and Ingress structure while preserving the described package and service contents.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: gforsyth, rg20, iroy30, bubullzz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding and enforcing yamllint checks.
Description check ✅ Passed The description is directly related to enforcing yamllint checks and explains the motivation and issue link.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant