Skip to content

fix(quality): resolve SonarQube S3490 and S1186 critical findings #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jul 24, 2026
Merged

fix(quality): resolve SonarQube S3490 and S1186 critical findings #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f7a8b
fix(quality): resolve SonarQube S3490 and S1186 critical findings
ramakrishnap-nv Jul 23, 2026
1dbe5c2
fix(build): use rmm's device_uvector declaration, not a hand-rolled f…
maxwbuckley Jul 23, 2026
ded5045
merge: resolve conflicts with main in branch_and_bound.cpp
ramakrishnap-nv Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/linear_programming/cuopt/initial_problem_check.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ double combine_finite_abs_bounds(f_t lower, f_t upper)

template <typename f_t>
struct violation {
violation() {}
violation() = default;
violation(f_t* _scalar) {}
__device__ __host__ f_t operator()(f_t value, f_t lower, f_t upper)
{
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cuopt/mathematical_optimization/utilities/internals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace internals {

class Callback {
public:
virtual ~Callback() {}
virtual ~Callback() = default;
};

enum class base_solution_callback_type { GET_SOLUTION, SET_SOLUTION };
Expand Down
10 changes: 6 additions & 4 deletions cpp/src/branch_and_bound/branch_and_bound.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,7 +1117,8 @@ struct nondeterministic_policy_t : tree_update_policy_t<i_t, f_t> {
tree.graphviz_node(log, node, label, value);
}

void on_node_completed(mip_node_t<i_t, f_t>*, node_status_t, branch_direction_t) override {}
void on_node_completed(mip_node_t<i_t, f_t>*, node_status_t, branch_direction_t) override
{ /* no-op */ }
};

template <typename i_t, typename f_t, typename WorkerT>
Expand Down Expand Up @@ -1145,8 +1146,9 @@ struct deterministic_policy_base_t : tree_update_policy_t<i_t, f_t> {
}
}

void on_numerical_issue(mip_node_t<i_t, f_t>*) override {}
void graphviz(search_tree_t<i_t, f_t>&, mip_node_t<i_t, f_t>*, const char*, f_t) override {}
void on_numerical_issue(mip_node_t<i_t, f_t>*) override { /* no-op */ }
void graphviz(search_tree_t<i_t, f_t>&, mip_node_t<i_t, f_t>*, const char*, f_t) override
{ /* no-op */ }
};

template <typename i_t, typename f_t>
Expand Down Expand Up @@ -1290,7 +1292,7 @@ struct deterministic_diving_policy_t
void update_objective_estimate(mip_node_t<i_t, f_t>* node,
const std::vector<i_t>& fractional,
const std::vector<f_t>& x) override
{
{ /* no-op */
}

void on_node_completed(mip_node_t<i_t, f_t>* node,
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/branch_and_bound/deterministic_workers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ class deterministic_diving_worker_pool_t
}

void collect_worker_events(deterministic_diving_worker_t<i_t, f_t>&, bb_event_batch_t<i_t, f_t>&)
{
{ /* no-op */
}
};

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/cuts/cuts.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ class scratch_pad_t {
template <typename i_t, typename f_t>
class mixed_integer_gomory_cut_t {
public:
mixed_integer_gomory_cut_t() {}
mixed_integer_gomory_cut_t() = default;
};

template <typename i_t, typename f_t>
Expand Down
12 changes: 6 additions & 6 deletions cpp/tests/distance_engine/waypoint_matrix_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class waypoint_matrix_waypoints_sequence_test_t
public ::testing::TestWithParam<
waypoint_matrix_params_t<waypoint_sequence_params_t<i_t, f_t>, i_t, f_t>> {
public:
waypoint_matrix_waypoints_sequence_test_t() {}
waypoint_matrix_waypoints_sequence_test_t() = default;

void SetUp() override
{
Expand All @@ -44,7 +44,7 @@ class waypoint_matrix_waypoints_sequence_test_t
this->expected_sequence_offsets = param.sequence_offsets;
}

void TearDown() override {}
void TearDown() override { /* no-op */ }

void test_compute_waypoint_sequence()
{
Expand Down Expand Up @@ -111,7 +111,7 @@ class waypoint_matrix_shortest_path_cost_t
public ::testing::TestWithParam<
waypoint_matrix_params_t<shortest_path_cost_params_t<f_t>, i_t, f_t>> {
public:
waypoint_matrix_shortest_path_cost_t() {}
waypoint_matrix_shortest_path_cost_t() = default;

void SetUp() override
{
Expand All @@ -131,7 +131,7 @@ class waypoint_matrix_shortest_path_cost_t
this->weights.data());
}

void TearDown() override {}
void TearDown() override { /* no-op */ }

void test_compute_shortest_path_costs()
{
Expand Down Expand Up @@ -173,7 +173,7 @@ class waypoint_matrix_cost_matrix_test_t
: public base_test_t<i_t, f_t>,
public ::testing::TestWithParam<waypoint_matrix_params_t<cost_matrix_params_t<f_t>, i_t, f_t>> {
public:
waypoint_matrix_cost_matrix_test_t() {}
waypoint_matrix_cost_matrix_test_t() = default;

void SetUp() override
{
Expand All @@ -192,7 +192,7 @@ class waypoint_matrix_cost_matrix_test_t
this->weights.data());
}

void TearDown() override {}
void TearDown() override { /* no-op */ }

void test_compute_cost_matrix()
{
Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/linear_programming/grpc/grpc_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,7 +1460,7 @@ class MockLogStream : public grpc::ClientReaderInterface<cuopt::remote::LogMessa
*sz = messages_[idx_].ByteSizeLong();
return true;
}
void WaitForInitialMetadata() override {}
void WaitForInitialMetadata() override { /* no-op */ }

private:
std::vector<cuopt::remote::LogMessage> messages_;
Expand Down
Loading