Skip to content

CI: suppress shell:S4830 false positive and scope GHA permissions to job level #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
May 18, 2026
Merged

CI: suppress shell:S4830 false positive and scope GHA permissions to job level #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5f799
ci: suppress SonarQube shell:S4830 on self-hosted server health probe
rgsl888prabhu May 15, 2026
ba4554f
ci: scope GitHub Actions permissions to the job level (SonarQube S826…
rgsl888prabhu May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions .github/workflows/build_test_publish_images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,11 @@ defaults:
run:
shell: bash

permissions:
actions: read
checks: none
contents: read
deployments: none
discussions: none
id-token: write
issues: none
packages: read
pages: none
pull-requests: read
repository-projects: none
security-events: none
statuses: none

jobs:
compute-matrix:
runs-on: ubuntu-latest
permissions:
contents: read
container:
image: rapidsai/ci-conda:26.06-latest
outputs:
Expand Down Expand Up @@ -111,6 +98,8 @@ jobs:
build-images:
name: Build images
needs: compute-matrix
permissions:
contents: read
secrets: inherit # zizmor: ignore[secrets-inherit]
strategy:
matrix: ${{ fromJson(needs.compute-matrix.outputs.MATRIX) }}
Expand All @@ -127,6 +116,8 @@ jobs:
build-cuopt-multiarch-manifest:
name: Build cuopt multiarch manifest
needs: [build-images, compute-matrix]
permissions:
contents: read
strategy:
matrix:
CUDA_VER: ${{ fromJson(needs.compute-matrix.outputs.MATRIX).cuda_ver }}
Expand Down Expand Up @@ -171,6 +162,8 @@ jobs:
test-images:
name: Test images
needs: [build-cuopt-multiarch-manifest, compute-matrix]
permissions:
contents: read
secrets: inherit # zizmor: ignore[secrets-inherit]
strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion ci/test_self_hosted_service.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ DELAY=10

sleep $DELAY

server_status=$(curl -k -sL https://0.0.0.0:$CUOPT_SERVER_PORT/cuopt/health)
server_status=$(curl -k -sL https://0.0.0.0:$CUOPT_SERVER_PORT/cuopt/health) # NOSONAR — self-signed cert generated locally by this script for CI; not a real TLS endpoint.

EXITCODE=0

Expand Down
Loading