BUG: Fix wrapping of nvrtcBundledHeadersInfo - #2754
Merged
Merged
Conversation
github-actions
Bot
added
the
cuda.bindings
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Sep 2, 2026
rwgk
left a comment
rwgk
left a comment
Contributor
There was a problem hiding this comment.
LGTM but see my question in an inline comment.
| NVRTC defines the following types and functions for bundled headers installation and management. | ||
|
|
||
| .. autoclass:: cuda.bindings.nvrtc.nvrtcBundledHeadersInfo | ||
| .. autoclass:: cuda.bindings.nvrtc.nvrtcBundledHeadersInfo |
Contributor
There was a problem hiding this comment.
There are two identical lines here now. Is that intentional? If not, is it harmless?
Contributor
Author
There was a problem hiding this comment.
It will document this twice. I think I'm still going to merge this as-is (and fix the doc bug in a follow-up), since the code is otherwise very broken and I'd like to get this in the next release.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to how the
nvrtcBundledHeadersInfostruct was spelled in the header, this caused our legacy generator to generate an unnecessary anonymous class and a class that it inherits from that can't be instantiated with its own memory.This uses a small fix in the generator to generate the right thing, and then adds some regression tests.
This was discovered while looking at the new bundled header APIs as part of #2363, but it is not required for that work -- the implementation there doesn't actually need to use these APIs directly anyway. This is just a latent bug for any users who want to use these new APIs directly from cuda-bindings.