[12.9.x backport] Refactor cuda-bindings setup.py to defer CUDA_HOME check to build time#1666
Merged
kkraus14 merged 1 commit intoNVIDIA:12.9.xfrom Feb 20, 2026
Merged
Conversation
NVIDIA#1652) * Refactor cuda-bindings setup.py to defer CUDA_HOME check to build time Move all CUDA-dependent logic (header parsing, code generation, cythonization) from setup.py into a custom PEP 517 build backend (build_hooks.py). Metadata queries (uv lock, uv sync, pip install --dry-run) no longer require CUDA_HOME or CUDA_PATH to be set. This follows the same pattern already used by cuda_core/build_hooks.py: - Metadata hooks delegate directly to setuptools - build_wheel/build_editable defer to _build_cuda_bindings() - setup.py becomes a thin shim for ext_modules + parallel build_ext Closes NVIDIA#1635 Co-authored-by: Cursor <cursoragent@cursor.com> * Address review feedback and restore PARALLEL_LEVEL compat - Move extra_link_args (strip) handling alongside extra_compile_args in the non-debug build path instead of a separate post-loop - Rename compiler_directives to cython_directives for clarity - Restore deprecated PARALLEL_LEVEL env var support in setup.py for build_ext parallelism parity with the old code Co-authored-by: Cursor <cursoragent@cursor.com> * Move clang detection to build_extensions for single check Check the compiler once in build_extensions (plural) and fix up all extensions in one pass, instead of checking per-extension in build_extension (singular). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
mdboom
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1652 to the
12.9.xbranch.cuda_bindings/build_hooks.pyas a custom PEP 517 build backendcuda_bindings/setup.pyas a thin shim (preserving 12.9.x-specific redirector code)pyproject.tomlbuild-backend fromsetuptools.build_metatobuild_hooksConflict resolution: kept
build_py_with_redirector,TopLevelFinderWithRedirector,editable_wheel_with_redirector, and the deprecatedcuda/*.pyxsource entry that are still present on12.9.x.Test plan
Closes #1635 (for 12.9.x)
Made with Cursor