refactor(examples): wrap logic in main() functions#1664
Open
OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
Open
refactor(examples): wrap logic in main() functions#1664OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
228ad87 to
4a7c9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the second half of the response to the following TODO item in
cuda_core/tests/example_tests/utils.py.see part 1
Key Changes
os.path.join(cuda_path, "include")refactor toPath(cuda_path) / "include"inthread_block_cluster.py.os.path.isdir(cuda_include)refactor tocuda_include.is_dir()inthread_block_cluster.py.codeblocks, they now have leading white space technically, this shouldn't break anything.Next Steps
contextlib.closingfor Stream and Buffer objects, current failed assertions will halt the execution of the example before.close()is called, thus cleanup is now the garbage collector's problem, this is non-deterministic though; since the Python's garbage collector is lazy, cleanup isn't immediate, not the end of the world but Streams or Buffers linger in the GPU drivers. I imagine many failed tests due to assertion errors may cause unneeded strain on GPU resources.Let me know if this sounds good (seems okay but not critical imo).