[REVIEW] Add count_if count_outer_if retrieve_if and retrieve_outer_if functions to static_multiset - #846
Open
MaybeWilli wants to merge 11 commits into
Open
[REVIEW] Add count_if count_outer_if retrieve_if and retrieve_outer_if functions to static_multiset#846MaybeWilli wants to merge 11 commits into
MaybeWilli wants to merge 11 commits into
Conversation
MaybeWilli
force-pushed
the
retrieve-count-if
branch
2 times, most recently
from
September 18, 2026 16:39
c24a72d to
ea3d382
Compare
MaybeWilli
marked this pull request as ready for review
September 20, 2026 20:16
MaybeWilli
requested review from
PointKernel and
sleeepyjack
as code owners
September 20, 2026 20:16
Member
|
@MaybeWilli Thanks for the contribution. There are a few cleanups I need to take care of first before we can move forward with this. Given how our downstream use cases have evolved, we probably no longer need to support the “outer” logic on the cuco side. I’ll let you know once this is ready to move forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800.
Adds if and outer_if functions for count and retrieve functions in static_multiset, to reduce unnecessary hash table lookups when the predicate is false.
Possible future update (left out of this PR for scope):
-Benchmark using
alongside count_if and retrieve_if, similar to how insert_if_n is being used, so that count and retrieve in kernels.cuh can be removed.