Fixes CLOUDAI-15: Updated copyright check#811
Merged
podkidyshev merged 2 commits intomainfrom Feb 17, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates copyright year metadata from 2024–2025/2024–2026 to 2025–2026 across the codebase and enhances the copyright header validation framework in tests with new utility functions for year-range formatting and git-based year extraction. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
podkidyshev
requested review from
amaslenn,
jeffnvidia and
srivatsankrishnan
as code owners
Contributor
Greptile SummaryThis PR implements a more robust copyright year checking system that validates copyright headers against actual git commit history. The new approach:
The PR updates 16 files to correct their copyright years based on this new validation logic. Most changes remove 2024 from files that were actually created/modified starting in 2025, correcting previously inaccurate copyright headers. Confidence Score: 5/5
Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/test_check_copyright_headers.py (1)
25-42: 🧹 Nitpick | 🔵 TrivialThe
"2024"inHEADER(line 26) is unused but could mislead readers.Since only
HEADER_TAIL(lines 2+) is compared, and line 1 is validated dynamically against git-derived years, the2024in the template is never actually checked. Consider adding a brief comment noting this, or replacing it with a placeholder likeYYYYto signal it's not compared.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/test_check_copyright_headers.py` around lines 25 - 42, The literal "2024" in HEADER is misleading because tests only compare HEADER_TAIL (HEADER_LINES[2:]) and the first-year line is validated dynamically from git; update the HEADER template to make this clear by either replacing the hardcoded year with a placeholder like "YYYY" or adding a brief inline comment near HEADER/HEADER_LINES noting that the first line is validated dynamically and not compared, so readers won't assume the literal year is used by the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/test_check_copyright_headers.py`:
- Around line 94-121: In get_commit_years_from_git, check the result of the
subprocess.run call stored in status (i.e. status.returncode) and emit a warning
or log a message when git status fails (non-zero) before relying on
status.stdout; include context (path_str) and status.stderr in the log to aid
debugging so that the CURRENT_YEAR append logic isn't silently skipped when git
status errored.
- Around line 124-138: get_commit_years_from_file returns years in the original
parse order which can make using actual_years[0] as the minimum incorrect;
update the implementation so it returns a sorted list (e.g., sorted(years)) or
ensure the consumer computes the min (in _assert_copyright_in_file where
actual_years[0] is used) by replacing that usage with min(actual_years) — modify
either get_commit_years_from_file or the call site to guarantee the earliest
year is correctly determined.
- Around line 156-164: The filtering step can produce an empty expected_years
which later causes _format_years_to_ranges (via prepare_copyright_with_year) to
raise a confusing ValueError; update the logic after calling
get_commit_years_from_git(file) to detect when expected_years is empty and
handle it explicitly — either by setting expected_years = [min_actual_year]
(fallback to the header's min year) or by raising an AssertionError/ValueError
with a clear message referencing get_commit_years_from_git and the file header;
adjust the block around get_commit_years_from_file(actual_copyright_lines[1]) /
get_commit_years_from_git(file) to implement this guard.
---
Outside diff comments:
In `@tests/test_check_copyright_headers.py`:
- Around line 25-42: The literal "2024" in HEADER is misleading because tests
only compare HEADER_TAIL (HEADER_LINES[2:]) and the first-year line is validated
dynamically from git; update the HEADER template to make this clear by either
replacing the hardcoded year with a placeholder like "YYYY" or adding a brief
inline comment near HEADER/HEADER_LINES noting that the first line is validated
dynamically and not compared, so readers won't assume the literal year is used
by the test.
Contributor
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@tests/test_check_copyright_headers.py`:
- Around line 113-120: The git status subprocess call assigns its result to
status but never checks status.returncode, so failures are silently ignored and
CURRENT_YEAR may not be appended to years; update the code around the
subprocess.run invocation (the call that sets status) to check status.returncode
and, if non-zero, emit a warning log (including status.returncode and
status.stderr) before continuing, so callers can debug why status.stdout is
empty while leaving the existing logic that appends CURRENT_YEAR to years when
appropriate.
- Around line 124-138: get_commit_years_from_file currently returns years in the
parsed order which can be non-monotonic; change it so the returned list is
sorted (e.g., return sorted(years)) so callers that rely on the first element
being the minimum (e.g., actual_years[0]) are correct; update the function
get_commit_years_from_file to sort the years before returning (or alternatively
adjust call sites to use min(actual_years) where used).
- Around line 156-164: The filter on expected_years can yield an empty list
(when min_actual_year is newer than all git years) causing
_format_years_to_ranges([]) to raise a confusing ValueError; modify the logic
around get_commit_years_from_git and the min_actual_year handling so that if
expected_years becomes empty after filtering you fall back to using
[min_actual_year] (or append min_actual_year to expected_years) before calling
prepare_copyright_with_year, ensuring functions get_commit_years_from_file,
get_commit_years_from_git, prepare_copyright_with_year and
_format_years_to_ranges are fed a non-empty list.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/test_check_copyright_headers.py`:
- Around line 147-168: Add an inline comment in the _assert_copyright_in_file
function near the computation of min_actual_year (where actual_years and
expected_years are derived and expected_years is filtered by min_actual_year)
that explicitly documents the trade-off: we trust the file's own minimum year as
ground truth because git --follow is unreliable, which means the test will
silently accept reductions of a file's start year (e.g., dropping 2024 → 2025)
and thus cannot detect accidental inflation/removal of earlier years; mention
this is intentional and point maintainers to get_commit_years_from_file and
get_commit_years_from_git for context.
- Around line 106-110: When handling git failures in the block that checks
res.returncode (the one that allows 128 = no commits match), add a debug-level
log of res.stderr whenever res.returncode == 128 before you fall through to
computing lines/years; keep the current behavior of defaulting to [CURRENT_YEAR]
for empty lines. Reference the existing variables res, res.returncode, and
res.stderr and ensure the log call runs only for the 128 branch so other
non-zero return codes still raise the RuntimeError; leave the lines and years
logic (lines = [...], years = ...) unchanged.
- Around line 124-138: The get_commit_years_from_file function is fragile
because it relies on brittle str.replace calls and will produce unclear
ValueError on malformed lines; update get_commit_years_from_file to use a
regular expression that extracts the years segment (or individual
year/year-range tokens) from the line, validate the regex match and raise a
clear ValueError if the expected pattern is not found, then parse tokens
(splitting on commas, handling ranges like "YYYY-YYYY") into ints and return the
sorted list of years. Ensure you reference get_commit_years_from_file when
locating the code to change.
- Around line 166-167: Update the two assertions that check
actual_copyright_lines[0] and [1] to include the file path in their failure
messages (same style as the following assertion that uses {file}); specifically
modify the assertion messages for the checks against HEADER_LINES[0] and
expected_years_line so they incorporate the {file} identifier and provide
context, referencing the variables actual_copyright_lines, HEADER_LINES,
expected_years_line and the {file} placeholder.
- Line 154: Update the failing assertion message to include the current file
path so CI failures are easier to debug: in the test that uses
actual_copyright_lines and HEADER_LINES (look for the assertion using these
symbols), change the message string to include the file variable (e.g., include
file or path) so the assertion reads something like "Copyright is missing or
incomplete for {file}".
- Around line 50-73: _format_years_to_ranges assumes callers pass sorted, unique
years but doesn't enforce it; update the start of the function to defensively
normalize the input by converting years into a sorted unique sequence (e.g.,
years = sorted(set(years))) so duplicates and unsorted inputs are handled
correctly before the existing range-building logic runs, preserving the current
empty-list ValueError behavior and using the normalized list for
range_start/range_end and the loop.
---
Duplicate comments:
In `@tests/test_check_copyright_headers.py`:
- Around line 94-121: The git status call in get_commit_years_from_git currently
ignores non-zero exit codes; add a guard like the git log block: after calling
subprocess.run for ["git", "status", "--porcelain", "--", path_str] check if
status.returncode != 0 and raise a RuntimeError (including path_str and
status.stderr) so failures (not being in a repo, corrupt index, etc.) are
surfaced instead of silently degrading the computed years; keep the existing
logic that appends CURRENT_YEAR only when status.stdout indicates changes.
amaslenn
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a new copyright check with the following requirements:
git log --followbehaviorTest Plan
Additional Notes