Draft
Conversation
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 19m: Pass: 100%/137 | Total: 1d 04h | Max: 1h 00m | Hits: 96%/272717See results here. |
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first, I thought it would be better to make the hierarchy groups specializations of a single class, but that design quite ugly and complicated.
After @fbusato's review on #7699, I think it would be better to make hiearachy group a concept. That way we can get rid of a lot of the metaprogramming and specializations and make it easier to implement new group kinds.
Currently the only requirements are specifying at what hierarchy level are the units grouped and the ability to synchronize the group. There may be more in the future as we move forward in the design