Skip to content

Remove some unused Thrust includes - #10885

Open
bernhardmgruber wants to merge 1 commit into
NVIDIA:mainfrom
bernhardmgruber:remove_thrust_includes
Open

Remove some unused Thrust includes#10885
bernhardmgruber wants to merge 1 commit into
NVIDIA:mainfrom
bernhardmgruber:remove_thrust_includes

Conversation

@bernhardmgruber

Copy link
Copy Markdown
Contributor

No description provided.

@bernhardmgruber
bernhardmgruber requested a review from a team as a code owner August 18, 2026 21:36
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Aug 18, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5ef4159f-96dc-451b-8048-9433447f3145

📥 Commits

Reviewing files that changed from the base of the PR and between 9f910bd and e98185e.

📒 Files selected for processing (5)
  • cub/cub/agent/agent_merge.cuh
  • cub/cub/block/radix_rank_sort_operations.cuh
  • cub/cub/device/dispatch/dispatch_streaming_reduce.cuh
  • cub/cub/device/dispatch/dispatch_streaming_reduce_by_key.cuh
  • cub/cub/device/dispatch/dispatch_transform.cuh
💤 Files with no reviewable changes (5)
  • cub/cub/agent/agent_merge.cuh
  • cub/cub/device/dispatch/dispatch_streaming_reduce_by_key.cuh
  • cub/cub/device/dispatch/dispatch_streaming_reduce.cuh
  • cub/cub/block/radix_rank_sort_operations.cuh
  • cub/cub/device/dispatch/dispatch_transform.cuh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed unused internal dependencies from several components.
    • No user-facing behavior or public interfaces changed.

Walkthrough

The pull request removes unused Thrust header includes from five CUB headers. It does not change declarations, runtime logic, or API behavior.

Changes

Header cleanup

Layer / File(s) Summary
Remove unused Thrust includes
cub/cub/agent/agent_merge.cuh, cub/cub/block/radix_rank_sort_operations.cuh, cub/cub/device/dispatch/dispatch_streaming_reduce.cuh, cub/cub/device/dispatch/dispatch_streaming_reduce_by_key.cuh, cub/cub/device/dispatch/dispatch_transform.cuh
Removed unused Thrust type-trait, iterator, and integer-sequence includes. CUDA standard-library facilities remain included directly where required.

Merge Risk: ⚪ Minimal · up to e9818

This PR only removes unused includes from five files, with no actionable merge-blocking risk remaining beyond normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 2h 57m: Pass: 100%/272 | Total: 13d 11h | Max: 2h 56m | Hits: 17%/1050212

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant