fix(whisper): match reference mel preprocessing - #1282
Draft
WenJing95 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: wj <126436871+WenJing95@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Nonzero audio edges produced different Whisper mel features because STFT used zero padding. The discarded final frame could also change the log floor.
Exit Criteria
Match reference features at chunk boundaries.
Implementation
Reflect both ends of the waveform and remove the last frame before normalization.
Change categories
Validation
Commands and Results
Native reference goldens passed at 80/128 mels; source-quality: 164 passed.
Hardware, Environment, and Revisions
8a95b0e: Ubuntu CPU, GCC 13.3; Transformers 5.2.0 reference.Not Run / Remaining Gaps
TensorRT inference and full CMake suite: TensorRT environment unavailable.
Contributor Self-Review
Notes For Future Readers
Reflect after padding/truncating to 30 seconds so short clips keep their zero-padded tail.
Risk level
Changes are confined to Whisper's center padding and log normalization.