Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummaryThe CI container now accepts a configurable MPI validation now sets Architecture impactHUMAN REVIEW REQUIRED
WalkthroughThe container build now accepts an ChangesContainer build configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The architecture argument propagation and MPI environment change do not leave an actionable merge risk in the reviewed configuration. 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
Comment |
ce50efa to
6031386
Compare
You can use a command such as the following, ```docker compose build --build-arg ARCH=$(uname -m)``` to build the CI container for x86_64 (or aarch64). - The default CPU architecture remains `aarch64` so CI doesn't break. - Prefix `mpirun` with `HWLOC_COMPONENTS=-gl` to avoid a hang when graphics are present on the GPU. Signed-off-by: Eric Work <work.eric@gmail.com>
6031386 to
892c1b2
Compare
|
Hey Eric, please add a short explanation under the risk level. There is also another failure, which is a gap in our CI: we need to add the docker-compose.yml to shared files in tools/test_impact.py and we should be good here |
Added
I'll take a look at this and update the PR. |
You can use a command such as the following,
docker compose build --build-arg ARCH=$(uname -m)to build the CI container for x86_64 (or aarch64).
aarch64so CI doesn't break.mpirunwithHWLOC_COMPONENTS=-glto avoid a hang when graphicsare present on the GPU.
Background
The current
docker composeworkflow doesn't support anything butaarch64due to hardcoding some paths. Make the CPU arch a build argument to supportx86_64as well.Exit Criteria
docker compose build --build-arg ARCH=$(uname -m)finishes successfully on a Linux x86 host (Fedora 44 + rootless podman) with an RTX 5080 GPU.Implementation
N/A: Just a build improvement.
Change categories
Validation
Commands and Results
docker compose build --build-arg ARCH=$(uname -m)Hardware, Environment, and Revisions
Not Run / Remaining Gaps
N/A: Just a build improvement.
Contributor Self-Review
Notes For Future Readers
N/A: Just a build improvement.
Risk level
This is a change only to the CI/developer Docker build, so it shouldn't have any product impact. The default value for the variable being added is the same as before so it should be a transparent change if the user doesn't exercise the variable.