Skip to content

test(ci): exercise unified CI policy with GPT-2 - #1267

Closed
chaofengw-nv wants to merge 1 commit into
NVIDIA:mainfrom
chaofengw-nv:test/gpt2-community-ci-live-fire
Closed

chaofengw-nv wants to merge 1 commit into
NVIDIA:mainfrom
chaofengw-nv:test/gpt2-community-ci-live-fire

Conversation

@chaofengw-nv

@chaofengw-nv chaofengw-nv commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Background

Live end-to-end validation of Community CI after #1268 retired the standalone CPU workflow and paused automatic GPU execution. No functional change; this PR exists only to exercise the current pull-request policy with a clean families/ change.

Exit Criteria

  • One Community CI workflow fires automatically for the rebased head; the retired standalone Community CPU workflow does not run.
  • Community CPU / Required succeeds before GPU authorization and impact classification.
  • GPU impact selection chooses only gpt2 and reports that automatic GPU execution is disabled.
  • GPU reservation, execution, cleanup, and result publication remain skipped, with GPU validation outside the merge gate.

Implementation

Add a comment-only annotation to families/gpt2/support.py. Model support, runtime behavior, validation criteria, and public interfaces are unchanged.

Change categories

  • CI or developer tooling

Validation

Commands and Results

  • python3 -m ruff check families/gpt2/support.py: passed.
  • python3 -m tools.community_ci impact --base github/main: passed; selected only gpt2 with family scope.
  • python3 -m tools.test_impact --base github/main --head HEAD: passed; selected only gpt2 and requested Core tests.
  • git diff --check github/main...HEAD: passed.

Hardware, Environment, and Revisions

Rebased onto github/main at f7c22339881f78e36ba138000e1dfa03f1943c07. Local validation used CPU-only tooling; the live pull-request workflow is the test target.

Not Run / Remaining Gaps

The optional manual GPU smoke is intentionally not requested. No GPU execution, model qualification, parity, or performance claim is made.

Contributor Self-Review

  • I have completed a self-review of this change.

Notes For Future Readers

This PR is not intended to merge. Close it after the unified CPU gate, GPU impact classification, and disabled-execution policy are observed.

Risk level

  • Low

Comment-only CI live-fire payload with no functional model change.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f8a2822e-8d7c-4ae8-b39d-b130f8349894

📥 Commits

Reviewing files that changed from the base of the PR and between 296f366 and f5093fe.

📒 Files selected for processing (1)
  • families/gpt2/support.py

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary

Adds a three-line comment to families/gpt2/support.py to trigger the ordered Community CI pipeline.

The change does not alter GPT-2 support, runtime behavior, validation criteria, public interfaces, or dependencies. Live GPU validation remains pending.

Architecture impact

  • Family-owned files: families/gpt2/support.py
  • Shared surfaces: None changed.
  • Dependency directions: None added.
  • Affected consumers: Community CI only.
  • Unresolved blast-radius questions: Confirm the live workflow produces the expected terminal GPU status and excludes unrelated model families.

Status: HUMAN REVIEW REQUIRED. Live workflow behavior remains unverified.

Walkthrough

The change adds a three-line comment to the GPT-2 support module. It documents an ordered Community CI live-fire payload. Runtime behavior remains unchanged.

Changes

GPT-2 support note

Layer / File(s) Summary
Add CI payload comment
families/gpt2/support.py
Documents the ordered Community CI live-fire payload and confirms that GPT-2 support and runtime behavior are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2c3b3

This documentation-only change introduces no production behavior or merge-blocking risk.

🚥 Pre-merge checks | ✅ 9
✅ Passed checks (9 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Family Ownership Boundary ✅ Passed PASS. The authoritative diff changes only families/gpt2/support.py, adding comment lines 6-7. The base and head retain the same family_support import and GPT-2 describe declaration. No import, i…
Shared Semantic Neutrality ✅ Passed PASS. The authoritative diff changes only families/gpt2/support.py, a family-owned support file, by adding three comment lines. The family_support declaration is unchanged after removing comments …
Benchmark Validation Integrity ✅ Passed PASS: The review-scoped diff changes only families/gpt2/support.py by adding a comment. The family_support import, describe declaration, model type, task, and default task are unchanged. No benc…
Shared Change Blast Radius ✅ Passed PASS: The authoritative diff changes only families/gpt2/support.py and adds three comments. The comments do not alter imports, declarations, runtime behavior, contracts, tooling, catalogs, or valida…
Title check ✅ Passed The title clearly identifies a CI policy test using GPT-2. It matches the comment-only change and the stated objective to exercise unified Community CI.
Description check ✅ Passed The description completes all required sections. It explains the purpose, exit criteria, implementation, change category, validation commands and results, environment, remaining gaps, self-review, not…

Comment @coderabbitai help to get the list of available commands.

Add a comment-only GPT-2 family change to exercise the ordered Community CPU and GPU pipeline introduced by NVIDIA#1262. This commit does not change model behavior or validation criteria.

Signed-off-by: chaofengw <chaofengw@nvidia.com>
@chaofengw-nv
chaofengw-nv force-pushed the test/gpt2-community-ci-live-fire branch from f5093fe to 2c3b302 Compare September 11, 2026 16:42
@chaofengw-nv chaofengw-nv changed the title test(ci): exercise ordered GPU pipeline with GPT-2 test(ci): exercise unified CI policy with GPT-2 Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant