Skip to content

[None][test] Unwaive GB300 MiniMax M3 NVFP4 test - #18400

Open
jieli-matrix wants to merge 1 commit into
NVIDIA:mainfrom
jieli-matrix:unwaive-gb300-minimax-m3-nvfp4
Open

[None][test] Unwaive GB300 MiniMax M3 NVFP4 test#18400
jieli-matrix wants to merge 1 commit into
NVIDIA:mainfrom
jieli-matrix:unwaive-gb300-minimax-m3-nvfp4

Conversation

@jieli-matrix

@jieli-matrix jieli-matrix commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

unwaive the test case, since NVFP4 already passed, the linked bug for test case: accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_mxfp8[use_msa=False] already fix and in verify stage

Dev Engineer Review

  • Removed the GB300 waiver for TestMiniMaxM3::test_nvfp4[use_msa=False].
  • The change correctly unwaives the test after NVFP4 passed.
  • The waiver file change is limited to one entry and does not alter public APIs or runtime code.
  • The related bug reference, NVBug 6681908, is removed with the obsolete waiver.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed the GB300 waiver entry for TestMiniMaxM3::test_nvfp4[use_msa=False].
  • The test-list format and scope remain consistent.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Jie Li <lijie@nvidia.com>
@jieli-matrix jieli-matrix self-assigned this Aug 29, 2026
@jieli-matrix
jieli-matrix requested a review from xxi-nv August 29, 2026 04:02
@jieli-matrix
jieli-matrix enabled auto-merge (squash) August 29, 2026 04:02
@jieli-matrix

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only waive tests"

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 48f941ff-6a01-43d7-8501-7dff9111dd3c

📥 Commits

Reviewing files that changed from the base of the PR and between 1acd695 and 49c5680.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration waiver list no longer skips TestMiniMaxM3::test_nvfp4[use_msa=False] on GB300. Its NVBug 6681908 reference was also removed.

Changes

GB300 waiver update

Layer / File(s) Summary
Remove MiniMax NVFP4 waiver
tests/integration/test_lists/waives.txt
The GB300 skip entry and NVBug 6681908 reference were removed for TestMiniMaxM3::test_nvfp4[use_msa=False].

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 49c56

This change re-enables the specified GB300 MiniMax M3 NVFP4 test by removing its waiver entry; no actionable merge-blocking risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise, specific, and follows the repository format. It clearly states that the GB300 MiniMax M3 NVFP4 test is being unwaived.
Description check ✅ Passed The description explains the reason for removing the waiver and states that NVFP4 passed. It also identifies the related test and bug status. The template sections are present, although the details ar…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Description check

Explanation

The description explains the reason for removing the waiver and states that NVFP4 passed. It also identifies the related test and bug status. The template sections are present, although the details are provided outside the Description and Test Coverage headings.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70109 [ skip ] triggered by Bot. Commit: 49c5680 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70109 [ skip ] completed with state SUCCESS. Commit: 49c5680
Skipping testing for commit 49c5680

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants