[None][test] Unwaive GB300 MiniMax M3 NVFP4 test - #18400
Conversation
Signed-off-by: Jie Li <lijie@nvidia.com>
|
/bot skip --comment "Only waive tests" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe integration waiver list no longer skips ChangesGB300 waiver update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change re-enables the specified GB300 MiniMax M3 NVFP4 test by removing its waiver entry; no actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Description checkExplanation The description explains the reason for removing the waiver and states that NVFP4 passed. It also identifies the related test and bug status. The template sections are present, although the details are provided outside the Description and Test Coverage headings. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
PR_Github #70109 [ skip ] triggered by Bot. Commit: |
|
PR_Github #70109 [ skip ] completed with state |
unwaive the test case, since NVFP4 already passed, the linked bug for test case: accuracy/test_llm_api_pytorch.py::TestMiniMaxM3::test_mxfp8[use_msa=False] already fix and in verify stage
Dev Engineer Review
TestMiniMaxM3::test_nvfp4[use_msa=False].NVBug 6681908, is removed with the obsolete waiver.QA Engineer Review
test-db/orqa/files were modified.TestMiniMaxM3::test_nvfp4[use_msa=False].Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.